Re: [PATCH v2] staging: most: video: Document locks in struct most_video_dev

From: Dan Carpenter

Date: Tue Nov 17 2026 - 08:09:00 EST


On Tue, Nov 17, 2026 at 12:03:55AM +0530, Shivani Patel wrote:
> checkpatch.pl reports that list_lock and lock in struct most_video_dev
> are defined without a comment.
>
> list_lock protects the pending_mbos list and the mute flag, which are
> accessed both from file operations and from the rx completion callback
> called by the MOST core. lock is assigned to vdev->lock and is used by
> the V4L2 core to serialize ioctls.
>
> Add short comments describing what each lock protects.
>
> Signed-off-by: Shivani Patel <patelshivani2283@xxxxxxxxx>
> ---
> v2:
> - Add a commit message and Signed-off-by (Andy Shevchenko)
> - Use the "staging: most: video:" subject prefix
> - Make the comments shorter and accurate
> - Drop the outreachy list (Julia Lawall)
>
> drivers/staging/most/video/video.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
> index 3a0445ff6..8833ab5c7 100644
> --- a/drivers/staging/most/video/video.c
> +++ b/drivers/staging/most/video/video.c
> @@ -33,6 +33,7 @@ struct most_video_dev {
> bool mute;
>
> struct list_head pending_mbos;
> + /* Protects @pending_mbos and @mute against the rx completion path */

Why is the rx path special? I feel like if you really look at
this code you will see things that can be done better. That's
what we really want from this kind of analysis.

regards,
dan carpenter