Re: [PATCH RESEND v4] rtc: abx80x: Don't warn about oscillator failure after POR

From: Fabio Estevam

Date: Tue Nov 17 2026 - 08:39:18 EST


On Wed, Sep 2, 2026 at 9:53 AM Fabio Estevam <festevam@xxxxxxxxx> wrote:
>
> From: Sean Anderson <sean.anderson@xxxxxxxx>
>
> According to the datasheet, the "oscillator failure" bit is set
>
> ...on a power on reset, when both the system and battery voltages have
> dropped below acceptable levels. It is also set if an Oscillator Failure
> occurs....
>
> From testing, this bit is also set if a software reset is initiated.
>
> This bit has a confusing name; it really tells us whether the time data
> is valid. We clear it when writing the time. If it is still set, that
> means there is a persistent issue, such as an oscillator failure,
> instead of a transient one, such as power loss.
>
> Because there are several other reasons which might cause this bit to be
> set, including booting for the first time or a battery failure, do not
> warn about oscillator failures unconditionally. This may cause system
> integrators to waste time investigating the wrong issue.
>
> Continue printing a message about invalid time data before the time has
> been set. Only report an oscillator failure after the driver has
> successfully written the time and cleared the flag.
>
> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxx>
> Signed-off-by: Fabio Estevam <festevam@xxxxxxxxxxxx>
> ---
> Changes since v3:
> - Rebase onto current mainline.
> - Fix commit message wording and typos.

Ping?