Re: [PATCH net] cxgb4: allocate the full ethtool filter location array
From: Potnuri Bharat Teja
Date: Tue Nov 17 2026 - 09:10:52 EST
On Tuesday, November 11/17/26, 2026 at 14:36:08 +0530, Artemii Mashanov wrote:
> The ethtool filter location array stores nentries u32 values, but
> cxgb4_init_ethtool_filters() passes nentries to kvzalloc() as a byte
> count. The insertion and lookup paths allow indices below nentries,
> which can address memory beyond the requested allocation.
>
> Allocate nentries elements with kvcalloc() and the element size.
> The array remains compatible with the existing kvfree() calls.
>
> The size mismatch was found by reviewing the allocation, the array
> declaration and the indexed accesses in the filter handlers.
>
> Fixes: d915c299f1da ("cxgb4: add skeleton for ethtool n-tuple filters")
> Signed-off-by: Artemii Mashanov <ralerrdirsardx@xxxxxxxxx>
> ---
> Compile-tested cxgb4_ethtool.o with GCC 14.2 on x86-64 net/main
> aa40afa831eb using W=1 and KCFLAGS=-Wno-error=format-truncation.
> Both baseline and patched builds reported the same get_drvinfo()
> format-truncation warning. Hardware validation is pending.
>
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c
> index 0092bc16f887..c72c0bcd45c8 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c
> @@ -2269,7 +2269,9 @@ int cxgb4_init_ethtool_filters(struct adapter *adap)
> eth_filter->nentries = nentries;
>
> for (i = 0; i < adap->params.nports; i++) {
> - eth_filter->port[i].loc_array = kvzalloc(nentries, GFP_KERNEL);
> + eth_filter->port[i].loc_array =
> + kvcalloc(nentries, sizeof(*eth_filter->port[i].loc_array),
> + GFP_KERNEL);
Thanks, Tested on T6, ethtool -N filters at high locations now insert and delete cleanly with KASAN enabled.
Reviewed-by: Potnuri Bharat Teja <bharat@xxxxxxxxxxx>
Tested-by: Potnuri Bharat Teja <bharat@xxxxxxxxxxx>
> if (!eth_filter->port[i].loc_array) {
> ret = -ENOMEM;
> goto free_eth_finfo;