Re: [PATCH 1/3] media: i2c: Add Sony IMX175 sensor driver

From: Uwe Kleine-König

Date: Tue Nov 17 2026 - 09:15:36 EST


On Mon, Nov 16, 2026 at 05:51:49PM +0000, Volodymyr Chapman wrote:
> +#include <linux/i2c.h>
> +#include <linux/mod_devicetable.h>

Please don't include <linux/mod_devicetable.h>. <linux/i2c.h> already
provides i2c_device_id, so you can just drop it.

> [...]
> +static const struct acpi_device_id imx175_acpi_ids[] = {
> + { "INTCF1A" },

Please make this:

{ .id = "INTCF1A" },


> + { }
> +};
> +MODULE_DEVICE_TABLE(acpi, imx175_acpi_ids);

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature