Re: [PATCH v3 2/2] block: return early when the elevator doesn't change

From: Nilay Shroff

Date: Tue Nov 17 2026 - 09:54:56 EST


On 11/17/26 8:26 AM, Qiliang Yuan wrote:
Writing the scheduler a queue already uses to queue/scheduler used to
be a no-op. elevator_change() now only checks for an unchanged elevator
after freezing the queue, and doesn't treat "none" on a queue without
an elevator as unchanged at all, so that case also quiesces the queue
in elevator_switch() and resets nr_requests.

Every such write therefore drains in-flight I/O and waits for an RCU
grace period. udev rules and tuning tools that set the scheduler
unconditionally stall I/O on live disks each time they run.

Check under elevator_lock whether anything would change before
allocating scheduler resources and freezing the queue. The check can
race with another elevator change, which at worst leads to a redundant
switch, so keep the one done under the freeze as well.

Writing the current scheduler to queue/scheduler of a null_blk disk 20
times takes (median):

operation before (ms) after (ms) change
none -> none 9.11 0.08 -99%
mq-deadline -> mq-deadline 9.05 0.08 -99%

4k random reads at queue depth 1 for 10 seconds, while "none" is
written to queue/scheduler every 50 ms:

metric before after change
IOPS 340562 390392 +15%
max latency (us) 16302 1224 -92%

Fixes: af2814149883e ("block: freeze the queue in queue_attr_store")
Signed-off-by: Qiliang Yuan<qiliang.yuan@xxxxxxxxx>
Reviewed-by: Christoph Hellwig<hch@xxxxxx>

Looks good to me:
Reviewed-by: Nilay Shroff <nilay@xxxxxxxxxxxxx>