[PATCH iwl-next 02/15] idpf: wipe mailbox send buffers on release

From: Stan Iliev

Date: Tue Nov 17 2026 - 09:56:27 EST


The mailbox messages are freed with kfree() once they were sent, or when
they couldn't be sent. Some messages hold secrets, e.g. the PSP TX keys
inserted into the SADB of the device. Free all of them with
kfree_sensitive() instead: the mailbox isn't a fast path.

Signed-off-by: Stan Iliev <stani@xxxxxxxxxx>
---
drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
index c06b2d9bfe0a..fedac4716b08 100644
--- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
+++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
@@ -129,7 +129,7 @@ void idpf_recv_event_msg(struct libie_ctlq_ctx *ctx,
*/
static void idpf_mb_clean(struct libie_ctlq_info *asq, bool deinit)
{
- libie_ctlq_xn_send_clean(asq, kfree, deinit);
+ libie_ctlq_xn_send_clean(asq, kfree_sensitive, deinit);
}

#if IS_ENABLED(CONFIG_PTP_1588_CLOCK)
@@ -218,7 +218,7 @@ int idpf_send_mb_msg(struct idpf_adapter *adapter,

if (err) {
if (!libie_cp_can_send_onstack(send_buf_size))
- kfree(send_buf);
+ kfree_sensitive(send_buf);

return err;
}
@@ -230,7 +230,7 @@ int idpf_send_mb_msg(struct idpf_adapter *adapter,
xn_params->send_buf.iov_len = send_buf_size;
xn_params->xnm = adapter->xnm;
xn_params->ctlq = xn_params->ctlq ? xn_params->ctlq : adapter->asq;
- xn_params->rel_tx_buf = kfree;
+ xn_params->rel_tx_buf = kfree_sensitive;
xn_params->timeout_ms = min_t(u64, xn_params->timeout_ms, timeout_ms);

idpf_mb_clean(xn_params->ctlq, false);
@@ -264,7 +264,7 @@ int idpf_send_mb_msg_kfree(struct idpf_adapter *adapter,
int err = idpf_send_mb_msg(adapter, xn_params, send_buf, send_buf_size);

if (libie_cp_can_send_onstack(send_buf_size))
- kfree(send_buf);
+ kfree_sensitive(send_buf);

return err;
}
--
2.56.0.679.gc527c65306-goog