Re: [PATCH net v3 3/3] net: stmmac: dwmac1000: stop hardware from dropping checksum-error packets

From: Maxime Chevallier

Date: Tue Nov 17 2026 - 09:59:17 EST


Hi,

On 11/14/26 14:36, Christian Schmidbauer wrote:
> When the checksum offload engine (CoE) is enabled, the dwmac1000 MAC
> silently drops any frame for which the engine detects a checksum error,
> before the driver sees it.
>
> This breaks VXLAN over IPv6 with zero UDP checksums, which RFC 6935 and
> RFC 6936 allow for tunnels.
>
> Set DMA_CONTROL_DT so that such frames are delivered instead of dropped,
> as commit fe4042797651 ("net: stmmac: dwmac4: stop hardware from
> dropping checksum-error packets") did for dwmac4. CoE remains enabled,
> so the driver still sees the error status and marks the skb
> CHECKSUM_NONE for the stack to verify.
>
> Set the bit only with enhanced descriptors. The normal descriptor parser
> does not report a checksum-only error to the stack, so cores that use
> it keep dropping such frames in hardware anyway.

I can confirm, I tested that on dwmac-meson8b (normal descriptors) and it
does drop.

I could confirm this works with enh descriptors, thanks !

Reviewed-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>
Tested-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>

Maxime

>
> Tested on an Aruba AP-325 (ipq806x-gmac-dwmac) with Rx checksum offload
> on.
>
> Link: https://lore.kernel.org/all/20250625132117.1b3264e8@xxxxxxxxxx/
> Link: https://github.com/freifunk-gluon/gluon/issues/3783
> Fixes: 47dd7a540b8a ("net: add support for STMicroelectronics Ethernet controllers.")
> Cc: <stable@xxxxxxxxxxxxxxx> # 6.6.x: ee0aace5f844: net: stmmac: Correctly handle Rx checksum offload errors
> Cc: <stable@xxxxxxxxxxxxxxx> # 6.6.x
> Assisted-by: Claude:claude-opus-4-8
> Signed-off-by: Christian Schmidbauer <opensource@xxxxxxxxxxx>
> ---
> Depends on patches 1 and 2 of this series.
>
> v3:
> - Move code comment of DMA_CONTROL_DT on the line of the define, similar
> to the original version in commit 47dd7a540b8a ("net: add support for
> STMicroelectronics Ethernet controllers.").
> v2:
> - Set DMA_CONTROL_DT only with enhanced descriptors. The normal
> descriptor parser does not report a checksum-only error, so cores
> with normal descriptors and Type 2 CoE keep the hardware drop.
> v1: https://lore.kernel.org/netdev/20261020190319.884375-1-opensource@xxxxxxxxxxx/
> drivers/net/ethernet/stmicro/stmmac/dwmac1000.h | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c | 8 ++++++++
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000.h b/drivers/net/ethernet/stmicro/stmmac/dwmac1000.h
> index 1de1f929d61c..55d9c39287f1 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac1000.h
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac1000.h
> @@ -162,7 +162,7 @@ enum rx_tx_priority_ratio {
> /* DMA CRS Control and Status Register Mapping */
>
> /* DMA operation mode defines (start/stop tx/rx are placed in common header)*/
> -/* Disable Drop TCP/IP csum error */
> +#define DMA_CONTROL_DT 0x04000000 /* Disable Drop of TCP/IP csum errors */
> #define DMA_CONTROL_RSF 0x02000000 /* Receive Store and Forward */
> #define DMA_CONTROL_DFF 0x01000000 /* Disaable flushing */
> /* Threshold for Activating the FC */
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c
> index 3ac7a7949529..31d5f79ef560 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c
> @@ -15,6 +15,7 @@
> #include <linux/io.h>
> #include "dwmac1000.h"
> #include "dwmac_dma.h"
> +#include "stmmac.h"
>
> static void dwmac1000_dma_axi(void __iomem *ioaddr, struct stmmac_axi *axi)
> {
> @@ -129,6 +130,13 @@ static void dwmac1000_dma_operation_mode_rx(struct stmmac_priv *priv,
> {
> u32 csr6 = readl(ioaddr + DMA_CHAN_CONTROL(channel));
>
> + /* Deliver checksum-error frames only with enhanced
> + * descriptors, because the normal descriptor parser does not
> + * report a checksum-only error.
> + */
> + if (priv->plat->enh_desc)
> + csr6 |= DMA_CONTROL_DT;
> +
> if (mode == SF_DMA_MODE) {
> pr_debug("GMAC: enable RX store and forward mode\n");
> csr6 |= DMA_CONTROL_RSF | DMA_CONTROL_DFF;