Re: [PATCH 1/3] MIPS: sgi-ip32: Clear latched CRIME errors at boot

From: Thomas Bogendoerfer

Date: Tue Nov 17 2026 - 12:03:15 EST


On Tue, Oct 13, 2026 at 11:45:52AM +0200, Imre Kaloz wrote:
> Errors already latched in CRIME when the kernel starts are reported as
> new, as a "CRIME memory error" or a "CRIME CPU error", once the error
> interrupts are enabled. Clear both status registers in crime_init().
>
> Signed-off-by: Imre Kaloz <kaloz@xxxxxxxxxx>
> ---
> arch/mips/sgi-ip32/crime.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/mips/sgi-ip32/crime.c b/arch/mips/sgi-ip32/crime.c
> index b8a0e4cfa9ce..d9f5fe939bfe 100644
> --- a/arch/mips/sgi-ip32/crime.c
> +++ b/arch/mips/sgi-ip32/crime.c
> @@ -34,6 +34,10 @@ void __init crime_init(void)
> crime = ioremap(CRIME_BASE, sizeof(struct sgi_crime));
> mace = ioremap(MACE_BASE, sizeof(struct sgi_mace));
>
> + /* Errors latched before the kernel starts would be reported as new */
> + crime->mem_error_stat = 0;
> + crime->cpu_error_stat = 0;
> +
> id = crime->id;
> rev = id & CRIME_ID_REV;
> id = (id & CRIME_ID_IDBITS) >> 4;
> --
> 2.47.3

applied to mips-next

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]