Re: [PATCH 1/3] dt-bindings: add STM32MP21 regulator bindings

From: Patrick DELAUNAY

Date: Tue Nov 17 2026 - 12:16:29 EST


Hi,

On 11/13/26 18:12, Conor Dooley wrote:
On Fri, Nov 13, 2026 at 03:10:39PM +0100, Patrick Delaunay wrote:
These bindings will be used for the SCMI voltage domain.

Signed-off-by: Patrick Delaunay <patrick.delaunay@xxxxxxxxxxx>
I don't believe these are bindings at all. Where is your software that
is using it?
They're no more bindings that interrupt numbers are, since they're
defined by the firmware, rather than what binding headers are normally
for: inventing meaning for numbers so that we can have an ABI.
These numbers arent even fixed, changing the firmware can change what
regulator these IDs represent, although anyone who would do that should
probably be taken around back.

IMO, if you want these definitions for your dts, move the header to the
dts directory.
pw-bot: changes-requested

Thanks,
Conor.


Ok, I do it in series V2.

thanks for the review  and the advice.

Patrick