Re: [PATCH 3/5] dt-bindings: iio: potentiometer: Add Analog Devices AD5246
From: Conor Dooley
Date: Tue Nov 17 2026 - 12:44:10 EST
On Mon, Nov 16, 2026 at 05:59:52PM -0500, Joseph Telaak wrote:
> The AD5246 is a 128-position digital rheostat on I2C, in 5, 10, 50 and
> 100 kOhm versions. The compatible names the resistance in kOhm, as for
> the AD5272. It uses the same protocol as the MCP4017/18/19, and the
> mcp4018 driver supports it, so list the binding with that driver in
> MAINTAINERS.
>
> It gets its own binding rather than a trivial-devices entry so that it
> can describe its supply and be an IIO channel provider
> (#io-channel-cells) for a consumer such as dpot-dac. There is no
> fallback to the MCP4017 compatibles: its resistance step is 1/128 of
> the end-to-end value, not 1/127.
Why is there no fallback between devices? Do the different resistance
values affect the logic? Please note that.
>
> Signed-off-by: Joseph Telaak <joseph@xxxxxxxxxx>
> ---
> .../bindings/iio/potentiometer/adi,ad5246.yaml | 54 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 55 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/potentiometer/adi,ad5246.yaml b/Documentation/devicetree/bindings/iio/potentiometer/adi,ad5246.yaml
> new file mode 100644
> index 000000000000..a6642746f002
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/potentiometer/adi,ad5246.yaml
Filename matching a compatible please.
pw-bot: changes-requested
Cheers,
Conor.
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/potentiometer/adi,ad5246.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD5246 digital rheostat
> +
> +maintainers:
> + - Joseph Telaak <joseph@xxxxxxxxxx>
> +
> +description: |
> + 128-position digital rheostat with an I2C interface. The compatible
> + names the end-to-end resistance in kOhm.
> +
> + Datasheet: https://www.analog.com/en/products/ad5246.html
> +
> +properties:
> + compatible:
> + enum:
> + - adi,ad5246-005
> + - adi,ad5246-010
> + - adi,ad5246-050
> + - adi,ad5246-100
> +
> + reg:
> + maxItems: 1
> +
> + vdd-supply: true
> +
> + "#io-channel-cells":
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> + - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + potentiometer@2e {
> + compatible = "adi,ad5246-010";
> + reg = <0x2e>;
> + vdd-supply = <®_3v3>;
> + #io-channel-cells = <0>;
> + };
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9cb91ee8a56d..81069fdbd778 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16680,6 +16680,7 @@ MCP4018 AND MCP4531 MICROCHIP DIGITAL POTENTIOMETER DRIVERS
> M: Peter Rosin <peda@xxxxxxxxxxxxxx>
> L: linux-iio@xxxxxxxxxxxxxxx
> S: Maintained
> +F: Documentation/devicetree/bindings/iio/potentiometer/adi,ad5246.yaml
> F: drivers/iio/potentiometer/mcp4018.c
> F: drivers/iio/potentiometer/mcp4531.c
>
>
> --
> Git-155)
>
Attachment:
signature.asc
Description: PGP signature