Re: [PATCH 0/3] media: Add Sony IMX175 sensor driver (Lenovo ThinkPad 10 rear camera)

From: Volodymyr Chapman

Date: Tue Nov 17 2026 - 12:56:36 EST


Hi Andy,

On Tue, Nov 17, 2026 at 12:08:07PM +0200, Andy Shevchenko wrote:
> > Not supported: the voice coil motor (the firmware does not name its
> > type) and the LM3554 flash.
>
> Why not flash? It's in the kernel provided by drivers/leds/leds-lm355x.c

I should have mentioned that leds-lm355x cannot be used on this machine as
it is: it only probes with platform data (it has no ACPI or DT matching,
and nothing in the tree provides the platform data), it does not drive the
LM3554's HWEN enable line, which has to be raised here before the chip
responds, and it registers plain LED class devices rather than a flash
LED class device.

When atomisp's own LM3554 driver was removed in commit f1aa35ab5943
("media: atomisp: Drop the atomisp custom lm3554 flash driver"), the
commit message said it should be re-implemented with the
led-class-flash API if it turned out to be needed, so that is what I
did. The new driver binds to the same ACPI ID (INTCF1C) and uses the
same GPIO order (0 strobe, 1 torch, 2 enable) as the removed one.

I have sent it to linux-leds:

https://lore.kernel.org/linux-leds/20261116180809.26946-1-volodymyrchapman@xxxxxxxxx/

Whether that or extending leds-lm355x is the better way is up to the LED
maintainers; I will ask on that thread. In v2 of this series, I will reword
the cover letter to point to it. The VCM has since turned out to be a
DW9714 at the address listed in _CRS, and I have a follow-up patch for
it which I can include in v2.

Thanks,
Volodymyr