[PATCH v2 1/2] rust: str: tie Formatter to its backing buffer
From: Peder Bergan via B4 Relay
Date: Tue Nov 17 2026 - 12:57:16 EST
From: Peder Bergan <peder.bergan@xxxxxxxxx>
Formatter::new() returns a Formatter whose lifetime is independent of the
borrow of its backing buffer. Safe code can therefore drop the buffer and
then write through the formatter, causing a use-after-free.
Tie the buffer borrow to the formatter's lifetime so that the borrow
checker rejects such callers and prevents overlapping mutable access.
Fixes: 87482d6d9104 ("rust: str: allow `str::Formatter` to format into `&mut [u8]`.")
Cc: stable@xxxxxxxxxxxxxxx
Reported-by: Georgios Androutsopoulos <georgeandrout13@xxxxxxxxx>
Closes: https://github.com/Rust-for-Linux/linux/issues/1261
Signed-off-by: Peder Bergan <peder.bergan@xxxxxxxxx>
---
rust/kernel/str.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/rust/kernel/str.rs b/rust/kernel/str.rs
index 644b4279a..e5fe84eeb 100644
--- a/rust/kernel/str.rs
+++ b/rust/kernel/str.rs
@@ -645,7 +645,7 @@ impl fmt::Write for RawFormatter {
/// Fails if callers attempt to write more than will fit in the buffer.
pub struct Formatter<'a>(RawFormatter, PhantomData<&'a mut ()>);
-impl Formatter<'_> {
+impl<'a> Formatter<'a> {
/// Creates a new instance of [`Formatter`] with the given buffer.
///
/// # Safety
@@ -658,7 +658,7 @@ impl Formatter<'_> {
}
/// Create a new [`Self`] instance.
- pub fn new(buffer: &mut [u8]) -> Self {
+ pub fn new(buffer: &'a mut [u8]) -> Self {
// SAFETY: `buffer` is valid for writes for the entire length for
// the lifetime of `Self`.
unsafe { Formatter::from_buffer(buffer.as_mut_ptr(), buffer.len()) }
--
2.56.1