Re: [PATCH v15 0/3] airoha: an7581: USB support
From: Christian Marangi (Ansuel)
Date: Tue Nov 17 2026 - 13:27:36 EST
Il giorno mar 3 nov 2026 alle ore 20:44 Christian Marangi
<ansuelsmth@xxxxxxxxx> ha scritto:
>
> This is a major rework of the old v2 series.
>
> The SoC always support USB 2.0 but for USB 3.0 it needs additional
> configuration for the Serdes port. Such port can be either configured
> for USB usage or for PCIe lines or HSGMII and these are configured
> in the SCU space.
>
> The previous implementation of a dedicated SSR driver was too
> complex and fragile for the simple task of configuring a register
> hence it was dropped and the handling is entirely in the PHY driver.
>
> Everything was reducted to the dt-bindings to describe the Serdes line.
>
> Also the property for the PHY are renamed to a more suitable name and
> everything is now mandatory to simplify the implementation.
> (the PHY are always present and active on the SoC)
>
> Also other unrelated patch are dropped from this series.
>
> Changes v15:
> - Rebase on phy/next
> - Add review tag
>
> Changes v14:
> - Drop blank lines at EOF for DT patch
> - Fix SPDX tag for move patch
>
> Changes v13:
> - Rebase on top of phy next
>
> Changes v12:
> - Rebase on top of linux-next now that clk patch got merged
>
> Changes v11:
> - Remove clk patch and move to dedicated series
>
> Changes v10:
> - Rebase on top of linux-next
> - Add review tag for DT patch
>
> Changes v9:
> - Add spinlock init
> - Add ack tag
> - Add review tag
> - Add additional comments for phys on USB 3.0
> - Add extra logic to make phys optional for USB 3.0
>
> Changes v8:
> - Squash header to clk Documentation patch
> - Address comments from AI Bot
> Link: https://lore.kernel.org/all/20260520150912.11614-1-ansuelsmth@xxxxxxxxx/
>
> Changes v7:
> - Rework to double PHY implementation
> (suggested by Rob)
> Now the clk driver expose a PHY for Serdes port
> USB PHY driver selects it
> - Rebase on top of linux-next
> Link: https://lore.kernel.org/all/20260519220813.28468-1-ansuelsmth@xxxxxxxxx/
>
> Changes v6:
> - Fix kernel test robot (sparse warning)
> Link: https://lore.kernel.org/all/20260306190156.22297-1-ansuelsmth@xxxxxxxxx/
>
> Changes v5:
> - Add Ack and Review tag from Connor
> - Implement Ethernet support in the USB driver
> (testing support for this Serdes on a special reference board)
> - Use an7581 prefix for USB PHY driver
> Link: https://lore.kernel.org/all/20251107160251.2307088-1-ansuelsmth@xxxxxxxxx/
>
> Changes v4:
> - Rename PCIe and USB PHY to AN7581
> - Drop airoha,scu (handled directly in driver)
> - Drop dt-bindings for monitor clock in favor of raw values
> - Better describe the usage of airoha,usb3-serdes
> - Simplify values of dt-bindings SSR SERDES
> Link: https://lore.kernel.org/all/20251107160251.2307088-1-ansuelsmth@xxxxxxxxx/
>
> Changes v3:
> - Drop clk changes
> - Drop SSR driver
> - Rename property in Documentation
> - Simplify PHY handling
> - Move SSR handling inside the PHY driver
> Link: https://lore.kernel.org/all/20251029173713.7670-1-ansuelsmth@xxxxxxxxx/
>
> Changes v2:
> - Drop changes for simple-mfd
> - Rework PHY node structure to single node
> - Drop port-id property in favor of serdes-port and
> usb2-monitor-clock-sel
> - Make the SSR driver probe from the clock driver
>
> Christian Marangi (3):
> dt-bindings: phy: Add documentation for Airoha AN7581 USB PHY
> phy: move and rename Airoha PCIe PHY driver to dedicated directory
> phy: airoha: Add support for Airoha AN7581 USB PHY
>
> .../bindings/phy/airoha,an7581-usb-phy.yaml | 61 ++
> MAINTAINERS | 11 +-
> drivers/phy/Kconfig | 11 +-
> drivers/phy/Makefile | 4 +-
> drivers/phy/airoha/Kconfig | 24 +
> drivers/phy/airoha/Makefile | 4 +
> .../phy-an7581-pcie-regs.h} | 0
> .../phy-an7581-pcie.c} | 6 +-
> drivers/phy/airoha/phy-an7581-usb.c | 559 ++++++++++++++++++
> 9 files changed, 663 insertions(+), 17 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/phy/airoha,an7581-usb-phy.yaml
> create mode 100644 drivers/phy/airoha/Kconfig
> create mode 100644 drivers/phy/airoha/Makefile
> rename drivers/phy/{phy-airoha-pcie-regs.h => airoha/phy-an7581-pcie-regs.h} (100%)
> rename drivers/phy/{phy-airoha-pcie.c => airoha/phy-an7581-pcie.c} (99%)
> create mode 100644 drivers/phy/airoha/phy-an7581-usb.c
>
> --
> 2.55.0
>
May I ask why this is still in this state? No report from sashiko, all
review tag...
Would love to have some feedback on how to proceed with this :(