Re: [PATCH v2] sched/topology: Avoid unsequenced accesses to jiffies in sd_init()

From: Nick Desaulniers

Date: Tue Nov 17 2026 - 13:39:40 EST


On Tue, Nov 17, 2026 at 10:30 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> I don't speak enough C legal to actually understand the Changelog, but
> the actual change seems daft. Is this really needed?

I would imagine a delta of the disassembly here before/after the
change would make it more obvious (one less volatile access, which be
have arbitrary ordering between initializing other members).

But I guess I'm also curious why jiffies is defined as volatile
anyway? I thought the usual guidance was to use
cast-to-volatile-qualified pointer during access, rather than declare
as volatile?

--
Thanks,
~Nick Desaulniers