Re: [PATCH 1/2] ASoC: ti: omap-mcbsp: Use all 8 bits of CLKGDV
From: Jarkko Nikula
Date: Tue Nov 17 2026 - 14:12:55 EST
Hi
On 11/17/26 12:03 AM, Joseph Telaak wrote:
CLKGDV is bits 7:0 of SRGR1, as its comment says and as set_clkdiv()Nice, this has been unnoticed since 2012.
intends with CLKGDV(0xff), but the macro masks the value with 0x7f, so
a divider above 128 is written modulo 128.
Mask with 0xff. The only set_clkdiv() user, omap3pandora, divides by 8,
so nothing changes for it; this lets the set_tdm_slot() support that
follows use dividers up to 256.
Signed-off-by: Joseph Telaak <joseph@xxxxxxxxxx>
---
sound/soc/ti/omap-mcbsp-priv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/ti/omap-mcbsp-priv.h b/sound/soc/ti/omap-mcbsp-priv.h
index da519ea1f303..324c5d7d431d 100644
--- a/sound/soc/ti/omap-mcbsp-priv.h
+++ b/sound/soc/ti/omap-mcbsp-priv.h
@@ -136,7 +136,7 @@ enum {
#define XPHASE BIT(15)
/************************* McBSP SRGR1 bit definitions ************************/
-#define CLKGDV(value) ((value) & 0x7f) /* Bits 0:7 */
+#define CLKGDV(value) ((value) & 0xff) /* Bits 0:7 */
#define FWID(value) (((value) & 0xff) << 8) /* Bits 8:15 */
Acked-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxx>