Re: [PATCH 5/5] iio: potentiometer: mcp4018: Add Analog Devices AD5246
From: Joseph Telaak
Date: Tue Nov 17 2026 - 14:32:54 EST
On Tue, Nov 17, 2026, Andy Shevchenko wrote:
> Make it shorter and more generic, in this way you spread the same text to the
> top comment in the file
> ...
> and to MODULE_DESCRIPTION().
Will do in v2, with your wording.
> And here make it list that is scalable to expand
Will do.
> Keep it sorted.
Will do, for the DEVID comment, the enum and the cfg table.
> Why signed? Can the HW return something negative?
No, I'll make it unsigned int in v2.
> Strictly speaking this patch can be split to two:
> - adding 'div' member and providing it for the existing chips
> - adding new chip support
Will split it in v2.