Re: [PATCH v2 07/11] dmaengine: arm-dma350: Query dma_cookie_status() under vc.lock in d350_tx_status()
From: Frank Li
Date: Tue Nov 17 2026 - 14:44:38 EST
On Tue, Nov 17, 2026 at 04:37:08PM +0000, Lee Jones wrote:
> Calling dma_cookie_status() before acquiring dch->vc.lock in
> d350_tx_status() races with d350_irq() completing the active descriptor
> and starting the next queued transfer, causing d350_tx_status() to
> observe a stale DMA_IN_PROGRESS status and falsely return DMA_ERROR.
>
> Move the dma_cookie_status() call inside the dch->vc.lock critical
> section.
>
> Fixes: 5d099706449d ("dmaengine: Add Arm DMA-350 driver")
> Closes: https://sashiko.dev/#/bug/linux-524816d7-ed1c-4f2b-b4c3-65a7e8bb45a3
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee@xxxxxxxxxx>
> ---
Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
>
> v1 => v2: No changes
>
> drivers/dma/arm-dma350.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/arm-dma350.c b/drivers/dma/arm-dma350.c
> index 52f5242ea332..8c1725588f1d 100644
> --- a/drivers/dma/arm-dma350.c
> +++ b/drivers/dma/arm-dma350.c
> @@ -381,9 +381,8 @@ static enum dma_status d350_tx_status(struct dma_chan *chan, dma_cookie_t cookie
> unsigned long flags;
> u32 residue = 0;
>
> + spin_lock_irqsave(&dch->vc.lock, flags);
> status = dma_cookie_status(chan, cookie, state);
> -
> - spin_lock_irqsave(&dch->vc.lock, flags);
> if (cookie == dch->cookie) {
> status = dch->status;
> if (status == DMA_IN_PROGRESS || status == DMA_PAUSED)
> --
> 2.56.0.679.gc527c65306-goog
>