Re: [PATCH v8 0/2] Add UFS Host driver support for SpacemiT K3 SoC

From: Aurelien Jarno

Date: Tue Nov 17 2026 - 14:45:26 EST


Hi,

On 2026-11-16 17:15, E Shattow wrote:
> Hi Yixun,
>
> On 11/15/26 19:46, Yixun Lan wrote:
> > This series try to add UFS support for SpacemiT K3 SoC, the controller
> > components consists of System Bus Interface Unit, UFS Host Controller
> > Interface, UFS Transport Protocol Layer, UFS Host Registers, Device
> > Management Entity (DME), Transport Layer, Network Layer, Data Link
> > Layer, PHY Adapter Layer, and M-PHY Interface. A more detail functional
> > block diagram can be found in SpacemiT website, chapter 9.7.3 [1]
> >
> > The DTS patch has been dropped in this series [2], and will send
> > in separate series once this patch accepted. For people who want to
> > test UFS driver, please grab the DT patch from version v5 [3].
> >
> > Enable UFSHCD_CAP_KEEP_AUTO_BKOPS_ENABLED_EXCEPT_SUSPEND,
> > This allows the device auto-bkops to be always enabled except
> > during suspend (both runtime and suspend), with this feature,
> > the BKOPS interrupt (log below) isn't reported anymore.
> >
> > [ 806.710763] ufshcd-spacemit c0e00000.ufshc: ufshcd_bkops_exception_event_handler: device raised urgent BKOPS exception for bkops status 1
> >
> > Link: https://spacemit.com/community/document/info?nodepath=hardware/key_stone/k3/k3_docs/k3_usermanual/09_memory_storage.md&lang=en [1]
> > Link: https://lore.kernel.org/all/20260918-belligerent-succinct-kraken-7fa592@quoll/ [2]
> > Link: https://lore.kernel.org/all/20260916-08-k3-ufs-support-v5-3-1f5d71f1027d@xxxxxxxxxx/ [3]
> > Signed-off-by: Yixun Lan <dlan@xxxxxxxxxx>
> > ---
> > Changes in v8:
> > - enable UFSHCD_CAP_KEEP_AUTO_BKOPS_ENABLED_EXCEPT_SUSPEND
> > - rename to "ref_clk", see explanation in patch
> > - add delay between enable clk & deassert reset
> > - respect bRefClkGatingWaitTime, add wait delay
> > - drop comment of ufs_hba_spacemit_vops, which got CI complaint
> > - rebase to v7.4-rc1
> > - Link to v7: https://patch.msgid.link/20261002-08-k3-ufs-support-v7-0-bb39007ff9ae@xxxxxxxxxx
> >
> > Changes in v7:
> > - check err return value of ufs_spacemit_quirk_host_pa_saveconfigtime()
> > - Link to v6: https://patch.msgid.link/20260921-08-k3-ufs-support-v6-0-3479768a2299@xxxxxxxxxx
> >
> > Changes in v6:
> > - drop unused macro and dev_req_params
> > - use global PX_xx macros
> > - fix axi clock name
> > - drop dts patch
> > - collect tags
> > - Link to v5: https://patch.msgid.link/20260916-08-k3-ufs-support-v5-0-1f5d71f1027d@xxxxxxxxxx
> >
> > Changes in v5:
> > - adjust clock names
> > - add runtime power support
> > - collect tags
> > - Link to v4: https://patch.msgid.link/20260908-08-k3-ufs-support-v4-0-22aa2bd97d3b@xxxxxxxxxx
> >
> > Changes in v4:
> > - fix clock and reset settings
> > - drop function which retrieve value of tx_lanes
> > - propagate return error of ufs_spacemit_dme_set()
> > - check return value ufs_spacemit_check_hibern8()
> > - drop call to ufshcd_vops_phy_initialization()
> > - handle compiling warning if CONFIG_OF not enabled
> > add __maybe_unused to ufs_spacemit_of_match
> > - Link to v3: https://patch.msgid.link/20260806-08-k3-ufs-support-v3-0-037fb322acdb@xxxxxxxxxx
> >
> > Changes in v3:
> > - collect tags
> > - fix dt-binding warning reported-by sashiko
> > - fix low freq in opp-2 table
> > - fix err checking in check_hibern8()
> > - propagate err code in link_startup_notify()
> > - update documents for event_notify()
> > - ufs clock driver is merged into v7.3-rc1, update cover letter
> > - Link to v2: https://patch.msgid.link/20260725-08-k3-ufs-support-v2-0-45036a2a2418@xxxxxxxxxx
> >
> > Changes in v2:
> > - fix missing interrupts property
> > - move ufs node to k3-com260.dtsi
> > - convert freq-table-hz to operating-points-v2
> > - rework reset_control, fix header and drop global variable
> > - drop dump_host_regs() debug interface
> > - converge and refactor dme_set() operations
> > - massive reduce of busy delay() loops
> > - drop vendor specific hce_enable_notify(), fallback to default
> > - drop unused member from struct ufs_spacemit_host
> > - add COMPILE_TEST support to Kconfig
> > - comment style fix
> > - Link to v1: https://patch.msgid.link/20260702-08-k3-ufs-support-v1-0-1a64a3ab128f@xxxxxxxxxx
> >
> > ---
> > Yixun Lan (2):
> > scsi: ufs: spacemit: dt-bindings: Add UFS controller for K3 SoC
> > scsi: ufs: spacemit: k3: Add UFS Host Controller driver
> >
> > .../devicetree/bindings/ufs/spacemit,k3-ufshc.yaml | 56 ++
> > drivers/ufs/host/Kconfig | 12 +
> > drivers/ufs/host/Makefile | 1 +
> > drivers/ufs/host/ufs-spacemit.c | 655 +++++++++++++++++++++
> > drivers/ufs/host/ufs-spacemit.h | 77 +++
> > 5 files changed, 801 insertions(+)
> > ---
> > base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
> > change-id: 20260605-08-k3-ufs-support-c8b308e415e2
> >
> > Best regards,
> > --
> > Yixun Lan <dlan@xxxxxxxxxx>
> >
> >
> > _______________________________________________
> > linux-riscv mailing list
> > linux-riscv@xxxxxxxxxxxxxxxxxxx
> > http://lists.infradead.org/mailman/listinfo/linux-riscv
>
> Tested v7 and v8 successfully on Sipeed K3 Pico-ITX (32GiB DRAM / 128GiB
> UFS model). Build and test methodology:
>
> ### build chimera debian-installer with patched mainline kernel
> ### assume fresh Debian testing "forky" build environment
>
> apt update
> apt install -y b4 bc bison ca-certificates cpio \
> crossbuild-essential-riscv64 curl debhelper fakeroot flex kmod \
> libdw-dev libssl-dev libssl-dev:riscv64 linux-config-7.2:riscv64 \
> python3 rsync
>
> curl -L \
> https://git.kernel.org/torvalds/t/linux-7.4-rc3.tar.gz \
> | tar xz
>
> pushd linux-7.4-rc3
> b4 am -v1 -o- \
> https://lore.kernel.org/all/20261115195112.32120-1-e@xxxxxxxxxxxx/ \
> | patch -p1
> b4 am -v5 -P3 -o- \
> https://lore.kernel.org/all/20260916-08-k3-ufs-support-v5-0-1f5d71f1027d@xxxxxxxxxx/ \
> | patch -p1

After applying that patch, you also need to change:
clock-names = "axi", "ref";
into
clock-names = "axi", "ref_clk";
to match the change done in the code in v8.

[...]

> I do notice some UFS-related warnings and errors in dmesg:
>
> journalctl --dmesg | grep ufshcd
> ufshcd-spacemit c0e00000.ufshc: freq-table-hz property not specified
> ufshcd-spacemit c0e00000.ufshc: ufshcd_populate_vreg: Unable to find
> vdd-hba-supply regulator, assuming enabled
> ufshcd-spacemit c0e00000.ufshc: ufshcd_populate_vreg: Unable to find
> vcc-supply regulator, assuming enabled
> ufshcd-spacemit c0e00000.ufshc: ufshcd_populate_vreg: Unable to find
> vccq-supply regulator, assuming enabled
> ufshcd-spacemit c0e00000.ufshc: ufshcd_populate_vreg: Unable to find
> vccq2-supply regulator, assuming enabled
> scsi host0: ufshcd
> ufshcd-spacemit c0e00000.ufshc: ufshcd_scsi_add_wlus: BOOT WLUN not found

I do have all those messages, I think they are just harmless.

> ufshcd-spacemit c0e00000.ufshc: DL error event, INT errors:0x4,
> DL_ERR:0x80000020

This one looks more worrying. I do not have it when testing. Does it
happens immediately or after a while? under load?

Regards
Aurelien

--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@xxxxxxxxxxx http://aurel32.net