Re: [PATCH v2 2/2] gpio: Add Siflower GPIO controller driver
From: Joseph Telaak
Date: Tue Nov 17 2026 - 14:49:26 EST
On Tue, Nov 17, 2026 at 11:38:53AM +0100, Linus Walleij wrote:
> So this has one register per setting per GPIO line?
Yes. Each line has its own block of registers, 0x40 apart: input,
output, output enable, the interrupt masks, the interrupt status, the
trigger type and the two filter registers. Only the pending bits are
shared, in one register per group of 16 lines.
> This is ideally handled with select GPIO_REGMAP
> for gpio-regmap.c using regmap-mmio, see for example
> see for example gpio-mvebu.c that does this elegantly.
I'll move it to gpio-regmap on regmap-mmio in v3, with a
reg_mask_xlate() for the 0x40 stride and the debounce in its
set_config(). gpio-regmap doesn't set up a gpio_irq_chip, and there is
one parent interrupt per group of 16 lines, so the interrupts move to an
IRQ domain of the driver's own, as in gpio-rtd1625.
Thanks,
Joseph