Re: [PATCH v2 11/11] dmaengine: dmatest: Avoid unsigned underflow in min_odd()

From: Frank Li

Date: Tue Nov 17 2026 - 14:51:47 EST


On Tue, Nov 17, 2026 at 04:37:12PM +0000, Lee Jones wrote:
> When either argument to min_odd() is zero (for example when a DMA device
> reports max_xor or max_pq as 0), val evaluates to 0 and val - 1
> underflows to UINT_MAX. In dmatest_func(), this sets src->cnt to
> UINT_MAX, which wraps around the (src->cnt + dst->cnt) >= 255 check and
> causes dmatest_alloc_test_data() to pass 0 to kcalloc() and dereference
> ZERO_SIZE_PTR.
>
> Return 0 from min_odd() when the minimum value is 0, and abort
> dmatest_func() if src->cnt is 0.
>
> Fixes: 8be9e32b310c ("dmatest: adjust invalid module parameters for number of source buffers")
> Closes: https://sashiko.dev/#/bug/linux-ca967586-4fc1-47a3-8616-4a9d21fe7455
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee@xxxxxxxxxx>
> ---

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

>
> v1 => v2: No changes
>
> drivers/dma/dmatest.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index 2ae3469397f3..5f768bb9a29f 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -457,6 +457,9 @@ static unsigned int min_odd(unsigned int x, unsigned int y)
> {
> unsigned int val = min(x, y);
>
> + if (!val)
> + return 0;
> +
> return val % 2 ? val : val - 1;
> }
>
> @@ -650,6 +653,9 @@ static int dmatest_func(void *data)
> } else
> goto err_thread_type;
>
> + if (!src->cnt)
> + goto err_free_coefs;
> +
> /* Check if buffer count fits into map count variable (u8) */
> if ((src->cnt + dst->cnt) >= 255) {
> pr_err("too many buffers (%d of 255 supported)\n",
> --
> 2.56.0.679.gc527c65306-goog
>