Re: [PATCH v3 3/9] sh: sq: Add missing kobject release callback to ktype_percpu_entry

From: Ian Rogers

Date: Tue Nov 17 2026 - 15:28:23 EST


On Sun, Nov 8, 2026 at 2:39 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> In sq_dev_add(), sq_kobject[cpu] is dynamically allocated with
> kzalloc_obj() and initialized with ktype_percpu_entry. When
> sq_dev_remove() calls kobject_put(kobj), the kobject is never freed
> because ktype_percpu_entry lacks a .release callback.
>
> Provide a sq_kobj_release() callback that calls kfree(kobj).
>
> Fixes: d7c30c682a27 ("sh: Store Queue API rework.")
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>

Gentle ping on this patch (moving SuperH maintainers to To: in case
this got buried in Cc:).

Danilo offered to take the full 9-patch kobj_type::release __must_init
series through the driver-core tree with subsystem ACKs, and this is
one of the last two patches awaiting an Acked-by. Does this look okay
to go via driver-core?

Thanks,
Ian

> ---
> arch/sh/kernel/cpu/sh4/sq.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/sh/kernel/cpu/sh4/sq.c b/arch/sh/kernel/cpu/sh4/sq.c
> index 908a8e09113b..f33864958487 100644
> --- a/arch/sh/kernel/cpu/sh4/sq.c
> +++ b/arch/sh/kernel/cpu/sh4/sq.c
> @@ -331,7 +331,13 @@ static const struct sysfs_ops sq_sysfs_ops = {
> .store = sq_sysfs_store,
> };
>
> +static void sq_kobj_release(struct kobject *kobj)
> +{
> + kfree(kobj);
> +}
> +
> static struct kobj_type ktype_percpu_entry = {
> + .release = sq_kobj_release,
> .sysfs_ops = &sq_sysfs_ops,
> .default_groups = sq_sysfs_groups,
> };
> --
> 2.56.0.455.g6c5a503b38-goog
>