Re: [RFC PATCH 0/2] mm: zsmalloc: make shrinker compaction budget-aware

From: Chris Wiseman

Date: Tue Nov 17 2026 - 22:19:45 EST


On Wed, Nov 18, 2026 at 11:25 AM Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> wrote:
>
> On (26/11/18 00:27), Chris Wiseman wrote:
> > Nhat / Johannes / Sergey - good with a 2-patch series that just removes
> > the zsmalloc shrinker and adds the unlocked zs_can_compact() pre-check
> > for manual zram compaction?
>
> If there is no shrinker now then does unlocked zs_can_compact() matter
> that much? I assume zs_can_compact() is now called only from external
> code, so it's not expected to be executed nearly as often as before, or
> is there some other reason to make it unlocked?

Ha, fair enough - started this whole thread trying to shave 70 us off
the shrinker and somehow talked ourselves into deleting the whole thing.
Definitely not worth adding lockless reads just for the occasional
manual zram compact.

Happy to drop the pre-check and just send a single patch removing the
zsmalloc shrinker once Nhat and Johannes are good with it.