回覆: [PATCH v2 6/9] i3c: mipi-i3c-hci: Add support for the AST2700 I3C controller

From: Billy Tsai

Date: Tue Nov 17 2026 - 22:27:55 EST


> > +int hci_extcap_vendor_ASPEED(struct i3c_hci *hci, void __iomem *base)
>
> function name don't mix low/up case.
>
> hci_extcap_vendor_aspeed()

hci_extcap_vendor_NXP() right above it is already all-caps for the
same reason: EXT_CAP_VENDOR()'s `.parser = (hci_extcap_vendor_##_vendor)`
token-pastes the name straight from EXT_CAP_VENDOR(NXP, ...) /
EXT_CAP_VENDOR(ASPEED, ...). Changing just ASPEED to lowercase would
make it inconsistent with NXP, and would need the macro invocation
changed too. I'd rather keep it matching the existing NXP precedent.

> > + return min_t(unsigned long, max_t(unsigned long, cycles, 1) - 1,
> > + ASPEED_I3C_PHY_CNT_MAX);
>
> now use min() and max() should be okay.

Confirmed with a build (W=1, cross-compiled); no warnings either way.
Simplified to min(max(cycles, 1) - 1, ASPEED_I3C_PHY_CNT_MAX).

> this part should be seperate patch, which not related add aspeed
> controler support.

Agreed. Split out into its own patch ("i3c: mipi-i3c-hci: Split the
core IRQ handling into its own function"), now patch 6, ahead of this
one.

Thanks

Billy Tsai