Re: [PATCH v2] media: xilinx: vip: Make use of the devm_clk_get_enabled()

From: Michal Simek

Date: Wed Nov 18 2026 - 06:58:07 EST




On 11/18/26 12:32, Mehdi Djait wrote:
Hi Michal,

On Wed, Nov 18, 2026 at 12:03:04PM +0100, Michal Simek wrote:
There is missing return value check from clk_prepare_enable(). Fix it by
using devm_clk_get_enabled() macro.

Signed-off-by: Michal Simek <michal.simek@xxxxxxx>
---

[..]

void xvip_cleanup_resources(struct xvip_device *xvip)
{
- clk_disable_unprepare(xvip->clk);

so the xvip_cleanup_resources() is empty after removing the
clk_disable_unprepare() call.

It is also called in xilinx-tpg.c and xilinx-vtc.c
Yes I know that it is empty.
But I would prefer to remove it in a separate patch.

Thanks,
Michal