Re: [PATCH v7 05/40] sched/deadline: Refuse dl_server debugfs writes while the rq is offline
From: Mathieu Desnoyers
Date: Wed Nov 18 2026 - 08:31:56 EST
> Does checking only !rq->online still leave a window during CPU
> deactivation where cpu_active(cpu) is already false while rq->online
> is still set?
Yes. On v6 I answered that the rq->online test would stay as it is. The
next version adds the cpu_active() test you suggest. The refusal then
covers the whole deactivation, so the window is gone.
On the way up, cpu_active() is set before rq->online. So the extra test
changes nothing there.
A write in that window left no wrong state in v7. The rebuild at the end
of sched_cpu_deactivate() resets total_bw and extra_bw. But the comment
says the refusal covers the whole offline, and now it does.
This was checked by reading, not reproduced.
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com