Re: [PATCH 0/2] crypto: ccp - fix misc_register() failure paths in SEV and SFS

From: Mario Limonciello

Date: Wed Nov 18 2026 - 11:05:34 EST




On 11/17/26 16:18, Kim Phillips wrote:
sev_misc_init() and sfs_misc_init() both publish their newly allocated
sev_misc_dev/sfs_misc_dev to a file-global pointer before registering
the misc device, then return early if misc_register() fails. Neither
frees the allocation nor clears the global, and the early return is
ahead of the kref_init(), so the embedded refcount is left at the zero
from kzalloc_obj().

Both features can be detected on more than one device, and a failure
here only aborts the probe of the device that hit it. The next device
to probe therefore sees a stale non-NULL global, takes the else branch,
and calls kref_get() on a zeroed refcount:

refcount_t: addition on 0; use-after-free.

The count stays at zero, so the matching kref_put() on teardown warns in
the same way and never reaches sev_exit()/sfs_exit(). What is left is a
leaked allocation plus a device whose ->misc points at a miscdevice that
was never registered, while the driver still reports the feature as
available and no /dev/sev or /dev/sfs node exists.

Both patches free the allocation and reset the global on the
misc_register() error path.

Note the differing Fixes: tags. The SEV stale-pointer half goes back to
the original SEV support commit, but the allocation was devm_kzalloc()
then, so backporting the kfree() that far would turn the leak into a
double free; the tag points at the commit from which the fix is safe.

Found by review of the equivalent bug reports; no hardware failure was
observed, as misc_register() only fails here on minor exhaustion or an
OOM. Compile-tested on x86_64 with CONFIG_CRYPTO_DEV_SP_PSP=y.

The two patches are independent of each other, and of the pending

https://lore.kernel.org/linux-crypto/20261116203622.615371-1-kim.phillips@xxxxxxx/

which touches psp-dev.c only. This series applies on top of it, but
also applies cleanly to cryptodev master without it.

Kim Phillips (2):
crypto: ccp - fix leak and stale misc_dev on SFS misc_register()
failure
crypto: ccp - fix leak and stale misc_dev on SEV misc_register()
failure

drivers/crypto/ccp/sev-dev.c | 5 ++++-
drivers/crypto/ccp/sfs.c | 5 ++++-
2 files changed, 8 insertions(+), 2 deletions(-)


base-commit: 26ca5f34841f0a86d0883664a1c13be89a01d351

Reviewed-by: Mario Limonciello (AMD) <superm1@xxxxxxxxxx>