Re: [PATCH 2/3] media: iris: Skip redundant HFI_PROP_TIER updates
From: bod
Date: Wed Nov 18 2026 - 11:07:24 EST
On 2026-10-31 01:49 +0530, Vishnu Reddy wrote:
> HFI_PROP_TIER is already programmed by iris_hfi_gen2_set_tier(), which
> selects TIER or TIER_AV1 based on the active codec. The TIER and TIER_AV1
> caps also define a .set callback. As a result, iris_set_properties()
> programs HFI_PROP_TIER again through the generic cap path.
>
> The generic property loop sets TIER first and TIER_AV1 last. For non AV1
> codecs, the TIER_AV1 property is programmed after the correct tier value
> and overrides it. Remove the .set callbacks from both caps. This ensures
> HFI_PROP_TIER is programmed only once with the value for the active codec.
I think this commit log should list where and how these settings can be
applied three times ? and what the sequence is exactly which leads to the
invalid setting.
It's not enomrously obvious reading the log and then the code how that
happens and which one is so obviously wrong.
---
bod