[PATCH RFC v3 28/31] drm/bridge: clear bridge->encoder on detach
From: Luca Ceresoli
Date: Wed Nov 18 2026 - 11:54:11 EST
Attaching a bridge to an encoder rightfully sets bridge->encoder to point
to the encoder. It also sets it to NULL in the error management path.
However drm_bridge_detach() does not set bridge->encoder to NULL.
This will create a potential NULL pointer dereference in a following commit
(part of when introducing DRM bridge hotplug) because drm_bridge_remove()
will have to detach bridges attached to an encoder, so it needs to use 'if
(bridge->encoder)' to know whether the bridge is attached to an
encoder. For this to work, the bridge->encoder pointer must NULL whenever
the bridge is not attached to an encoder.
Signed-off-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>
---
Issue found by sashiko:
https://lore.kernel.org/all/20261001131425.A001E1F000FF@xxxxxxxxxxxxxxx/
---
drivers/gpu/drm/drm_bridge.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
index a29f3e60bb24..ea7ed2c3bece 100644
--- a/drivers/gpu/drm/drm_bridge.c
+++ b/drivers/gpu/drm/drm_bridge.c
@@ -736,6 +736,7 @@ void drm_bridge_detach(struct drm_bridge *bridge)
drm_hotplug_event_notifier_notify(DRM_BRIDGE_DETACHED, bridge);
bridge->dev = NULL;
+ bridge->encoder = NULL;
drm_bridge_put(bridge);
}
--
2.56.1