Re: [PATCH v2 1/2] remoteproc: k3: Report a remote crash to the remoteproc core
From: Francesco Valla
Date: Wed Nov 18 2026 - 11:57:31 EST
Hi Chrispine,
On Mon, Nov 16, 2026 at 09:41:44PM +0300, Chrispine Tinega wrote:
> A K3 remote core that faults can send RP_MBOX_CRASH over the mailbox,
> but k3_rproc_mbox_callback() only logs it. The remoteproc core never
> learns of the crash, so its recovery never runs, the crash is not
> counted, and the core stays halted with every rpmsg channel to it dead.
>
> Call rproc_report_crash(), which may be called from atomic context. The
> core then moves to RPROC_CRASHED and the crash is counted. Where the
> driver leaves recovery enabled, recovery stops the core and boots it
> again. Where recovery is disabled, the core can still be stopped and
> started again through sysfs.
>
> Recovery on its own cannot yet restart an R5F: the reset the R5F needs
> before it starts again is applied in its unprepare() op, which sysfs
> stop calls and recovery does not. The R5F driver keeps recovery
> disabled, so this does not change what happens there.
>
Did you have the chance to take a look at the review sashiko did [1]?
I think the points about the leaks in IPC mode make sense and are worth
an investigation, both for the M4 and R5F cases.
> Signed-off-by: Chrispine Tinega <dev@xxxxxxxxxxxxxxxxxxx>
> ---
> Changes in v2:
> - Drop the dev_err(). rproc_report_crash() already logs the crash
> and names the core. (Francesco)
> - Say in the commit message that recovery cannot yet restart an R5F.
> (Francesco)
>
> drivers/remoteproc/ti_k3_common.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/remoteproc/ti_k3_common.c b/drivers/remoteproc/ti_k3_common.c
> index 4b6da3363..43a7a21fd 100644
> --- a/drivers/remoteproc/ti_k3_common.c
> +++ b/drivers/remoteproc/ti_k3_common.c
> @@ -60,11 +60,7 @@ void k3_rproc_mbox_callback(struct mbox_client *client, void *data)
>
> switch (msg) {
> case RP_MBOX_CRASH:
> - /*
> - * remoteproc detected an exception, but error recovery is not
> - * supported. So, just log this for now
> - */
> - dev_err(dev, "K3 rproc %s crashed\n", rproc->name);
> + rproc_report_crash(rproc, RPROC_FATAL_ERROR);
> break;
> case RP_MBOX_ECHO_REPLY:
> dev_info(dev, "received echo reply from %s\n", rproc->name);
> --
> 2.53.0
>
>
Regards,
Francesco
[1] https://sashiko.dev/#/patchset/20261116184146.1897281-1-dev%40chrispinetinega.com