Re: [PATCH net v2] udp_tunnel: fix GRO callback mismatch during setup
From: Simon Horman
Date: Wed Nov 18 2026 - 12:28:17 EST
On Wed, Nov 18, 2026 at 04:36:50PM +0100, Jérémy Jean wrote:
> On 2026-11-18 16:32, Simon Horman wrote:
> > On Sun, Nov 15, 2026 at 10:51:45PM +0000, netdev-bot+sashiko@xxxxxxxxxx
> > wrote:
> > > Thank you for your contribution! Sashiko AI review found 4 potential
> > > issue(s) to consider.
> > >
> > > Critical: 0 · High: 1 · Medium: 2 · Low: 1
> > >
> > > If you believe none of the issues are legitimate, please reply to each
> > > issue of Medium severity or higher and explain why the AI is wrong.
> > > If any of them are legitimate and you plan to respin, please let
> > > patchwork
> > > know by including "pw-bot: cr" as a separate line at the end of your
> > > reply
> > > (one such reply per series is enough).
> > >
> > > - [High] The fix still lets receive and completion use different
> > > tunnel
> > > parsers on the same packet, so the out-of-bounds write the commit…
> > > - [Medium] udp_tunnel_gro_count only describes how the head skb of a
> > > GRO
> > > entry was parsed, not the packets merged into it, so packets in the…
> > > - [Medium] The Fixes: tag blames only 5d7f5b2f6b93 ("udp_tunnel: use
> > > static call for GRO hooks when possible", v6.16), but part of what
> > > the…
> > > - [Low] The new synchronize_net() in udp_tunnel_update_gro_rcv()
> > > (net/ipv4/udp_offload.c:139) runs with the global…
> > >
> >
> > Hi Jérémy,
> >
> > I would appreciate it if you could provide feedback on
> > the concerns raised in this AI-generated review.
>
> Hello,
>
> I intend to do this at some point, but I have been busy with other
> non kernel things recently. I hope to get back to this at some point when
> I find time.
Ack, thanks in advance.