Re: [PATCH net v2] ipvlan: update port flags only after ipvlan_set_port_mode() succeeds
From: Simon Horman
Date: Wed Nov 18 2026 - 12:57:12 EST
On Mon, Nov 16, 2026 at 01:50:54PM +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
>
> Critical: 0 · High: 1 · Medium: 0 · Low: 0
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [High] The fix is incomplete.
Hi Wenbo,
This does seem of concern. Could you comment on this?
> --
>
> ipvlan: update port flags only after ipvlan_set_port_mode() succeeds
>
> This patch moves the write of the shared port->flags in ipvlan_link_new()
> to after ipvlan_set_port_mode() has succeeded. The goal is that a failed
> creation of a second ipvlan on an active port does not change the flags
> of the ipvlan interfaces that already exist.
>
> > diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
> > index f29864db662aa..5732b167c5b3c 100644
> > --- a/drivers/net/ipvlan/ipvlan_main.c
> > +++ b/drivers/net/ipvlan/ipvlan_main.c
>
> [ ... ]
>
> > @@ -691,6 +685,12 @@ int ipvlan_link_new(struct net_device *dev, struct rtnl_newlink_params *params,
> > if (err)
> > goto unlink_netdev;
> >
> > + /* Flags are per port and latest update overrides. User has
> > + * to be consistent in setting it just like the mode attribute.
> > + */
> > + if (data && data[IFLA_IPVLAN_FLAGS])
> > + port->flags = nla_get_u16(data[IFLA_IPVLAN_FLAGS]);
> > +
>
> [Severity: High]
> Can a failed RTM_NEWLINK still overwrite the shared port->flags here?
>
> The commit message says:
>
> "Defer updating port->flags until after ipvlan_set_port_mode() succeeds,
> after which ipvlan_link_new() has no remaining failure paths."
>
> When ipvlan_link_new() returns 0, the creation is not yet committed. The
> caller, rtnl_newlink_create(), can still fail after ops->newlink():
>
> net/core/rtnetlink.c:rtnl_newlink_create() {
> ...
> err = rtnl_configure_link(dev, ifm, portid, nlh);
> if (err < 0)
> goto out_unregister;
> if (tb[IFLA_MASTER]) {
> netdev_lock_ops(dev);
> err = do_set_master(dev, nla_get_u32(tb[IFLA_MASTER]), extack);
> netdev_unlock_ops(dev);
> if (err)
> goto out_unregister;
> }
> ...
> out_unregister:
> if (ops->newlink) {
> LIST_HEAD(list_kill);
>
> ops->dellink(dev, &list_kill);
> unregister_netdevice_many(&list_kill);
> ...
> }
>
> For ipvlan, the dellink callback is ipvlan_link_delete(), which calls
> __ipvlan_link_delete(). Neither function restores port->flags. When
> port->count > 1, the shared port survives with the flags from the failed
> request.
>
> The IFLA_MASTER failure is easy to trigger. A new ipvlan has no master
> upper device, so do_set_master() goes straight to the ifindex lookup. That
> returns -EINVAL for a nonexistent ifindex, or -EOPNOTSUPP for a device
> without ndo_add_slave, such as lo.
>
> For example, with ipv1 on eth0 in bridge mode, this command fails but
> leaves ipv1 in private mode:
>
> ip link add link eth0 name ipv2 master lo type ipvlan mode l2 private
>
> The port->mode change made by ipvlan_set_port_mode() also persists on this
> path. Moving the assignment within ipvlan_link_new() cannot cover this
> case.
>
> Would this need port state to be saved and restored across the whole
> rtnl transaction, for example by restoring it from dellink when creation
> is rolled back?
>
> > mutex_lock(&port->pnodes_lock);
> > list_add_tail_rcu(&ipvlan->pnode, &port->ipvlans);
> > mutex_unlock(&port->pnodes_lock);
>
> --
> Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261112064821.85624-1-sunwenbo%40cmss.chinamobile.com