Re: [PATCH vV 1/2] dt-bindings: ipmi: Convert starfive,kcs-bmc to DT schema

From: Conor Dooley

Date: Wed Nov 18 2026 - 12:57:58 EST


On Wed, Nov 18, 2026 at 02:25:25PM +0800, Mason Huo wrote:
> Convert the starfive,kcs-bmc binding to DT schema format.

This is not a conversion since you are not deleting anything?

>
> Signed-off-by: Mason Huo <mason.huo@xxxxxxxxxxxxxxxx>
> ---
> .../bindings/ipmi/starfive,kcs-bmc.yaml | 53 +++++++++++++++++++
> 1 file changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/ipmi/starfive,kcs-bmc.yaml
>
> diff --git a/Documentation/devicetree/bindings/ipmi/starfive,kcs-bmc.yaml b/Documentation/devicetree/bindings/ipmi/starfive,kcs-bmc.yaml
> new file mode 100644
> index 000000000000..2cb91d321a32
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ipmi/starfive,kcs-bmc.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ipmi/starfive,kcs-bmc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: StarFive BMC KCS Devices
> +
> +maintainers:
> + - Mason Huo <mason.huo@xxxxxxxxxxxxxxxx>
> +
> +description:
> + The StarFive BMC SoCs use Keyboard-Controller-Style (KCS) interfaces on
> + the eSPI bus for in-band IPMI communication with their host. The KCS
> + channels are part of a Super I/O (SIO) block and each channel occupies a
> + 0x100 byte register window, starting at offset 0x200 of the SIO register
> + space. A channel is identified by its register offset and the
> + "starfive,sio-id" of the parent SIO node.

Where is the binding for the parent SIO node? Hard to review this
without that I think.

> +
> +properties:
> + compatible:
> + enum:
> + - starfive,jhb100-kcs-bmc
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + items:
> + - description: KCS channel interrupt
> + - description: eSPI bus reset de-assertion interrupt
> +
> + interrupt-names:
> + items:
> + - const: kcs
> + - const: espi_rst

No need to have "rst" since this is a reset by nature ;)

> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + kcs@200 {

s/kcs/ipmi/?

> + compatible = "starfive,jhb100-kcs-bmc";
> + reg = <0x200 0x100>;
> + interrupts = <282>, <57>;
> + interrupt-names = "kcs", "espi_rst";
> + };
> --
> 2.50.1
>

Attachment: signature.asc
Description: PGP signature