Re: [PATCH v2] KVM: PPC: Book3S HV: Clean up on uvmem initialization failure
From: Fabiano Rosas
Date: Wed Nov 18 2026 - 13:47:53 EST
Haoxiang Li <haoxiang_li2024@xxxxxxx> writes:
> When kvmppc_uvmem_init() fails, kvmppc_book3s_init_hv() returns
> directly, bypassing the existing error path. Jump to the existing
> error path to clean up before returning the error.
>
> Fixes: 175be7e5800e ("KVM: PPC: Book3S HV: Free allocated memory if module init fails")
> Signed-off-by: Haoxiang Li <haoxiang_li2024@xxxxxxx>
> ---
> Changes in v2:
> - Change the Fixes tag.
> - Modify the patch title.
> ---
> arch/powerpc/kvm/book3s_hv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
> index 22283d46e8fe..620097f292b8 100644
> --- a/arch/powerpc/kvm/book3s_hv.c
> +++ b/arch/powerpc/kvm/book3s_hv.c
> @@ -6743,7 +6743,7 @@ static int kvmppc_book3s_init_hv(void)
> r = kvmppc_uvmem_init();
> if (r < 0) {
> pr_err("KVM-HV: kvmppc_uvmem_init failed %d\n", r);
> - return r;
> + goto err;
> }
>
> #if defined(CONFIG_KVM_XICS)
Reviewed-by: Fabiano Rosas <farosas@xxxxxxx>