RE: [PATCH v6 03/31] cxl: Move component register defines to uapi/cxl/cxl_regs.h
From: Manish Honap
Date: Wed Nov 18 2026 - 14:27:20 EST
> -----Original Message-----
> From: Alex Williamson <alex@xxxxxxxxxxx>
> Sent: Thursday, November 5, 2026 5:23 AM
> To: Manish Honap <mhonap@xxxxxxxxxx>
> Cc: jgg@xxxxxxxx; Ankit Agrawal <ankita@xxxxxxxxxx>; jic23@xxxxxxxxxx;
> dave.jiang@xxxxxxxxx; alejandro.lucero-palau@xxxxxxx; Srirangan
> Madhavan <smadhavan@xxxxxxxxxx>; corbet@xxxxxxx;
> skhan@xxxxxxxxxxxxxxxxxxx; dave@xxxxxxxxxxxx; alison.schofield@xxxxxxxxx;
> vishal.l.verma@xxxxxxxxx; iweiny@xxxxxxxxxx; ming.li@xxxxxxxxxxxx; Yishai
> Hadas <yishaih@xxxxxxxxxx>; Shameer Kolothum Thodi
> <skolothumtho@xxxxxxxxxx>; kevin.tian@xxxxxxxxx; bhelgaas@xxxxxxxxxx;
> dmatlack@xxxxxxxxxx; kees@xxxxxxxxxx; gustavoars@xxxxxxxxxx; Neo Jia
> <cjia@xxxxxxxxxx>; Krishnakant Jaju <kjaju@xxxxxxxxxx>; Vikram Sethi
> <vsethi@xxxxxxxxxx>; Zhi Wang <zhiw@xxxxxxxxxx>; linux-
> doc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; kvm@xxxxxxxxxxxxxxx;
> linux-cxl@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; linux-
> kselftest@xxxxxxxxxxxxxxx; linux-hardening@xxxxxxxxxxxxxxx; alex@xxxxxxxxxxx
> Subject: Re: [PATCH v6 03/31] cxl: Move component register defines to
> uapi/cxl/cxl_regs.h
>
> External email: Use caution opening links or attachments
>
>
> On Fri, 16 Oct 2026 21:48:10 +0530
> <mhonap@xxxxxxxxxx> wrote:
> > diff --git a/include/uapi/cxl/cxl_regs.h b/include/uapi/cxl/cxl_regs.h
> > new file mode 100644 index 000000000000..276f9361c840
> > --- /dev/null
> > +++ b/include/uapi/cxl/cxl_regs.h
> > @@ -0,0 +1,56 @@
> > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> > +/* Copyright (c) 2026 NVIDIA Corporation & Affiliates */
> > +
> > +#ifndef _UAPI_CXL_REGS_H_
> > +#define _UAPI_CXL_REGS_H_
> > +
> > +#include <linux/bits.h>
> > +#include <linux/const.h>
> > +
> > +/* CXL r4.0 sec 8.2.3 Component Register Layout and Definition */
> > +#define CXL_COMPONENT_REG_BLOCK_SIZE 0x10000
> > +
> > +/* CXL r4.0 sec 8.2.4 CXL.cache and CXL.mem Registers */ #define
> > +CXL_CM_OFFSET 0x1000 #define CXL_CM_CAP_HDR_OFFSET 0x0
> > +#define CXL_CM_CAP_HDR_ID_MASK __GENMASK(15, 0)
>
> A local sashiko review asks if this new uapi header should include
> asm/bitsperlong.h since __GENMASK requires __BITS_PER_LONG. We include
> the other two header dependencies, but not this one, so it's a bit self-
> inconsistent.
>
Okay, I will add it in v7.
> BTW, current guidance on the Assisted-by tag: 1e035297ffda ("docs:
> remove Assisted-by references"). Thanks,
>
> Alex
Okay, I will drop this in v7 and update the cover letter as per new guidance.
Thanks,
Manish