RE: [PATCH net-next v11 07/14] net: ethernet: oa_tc6: Support for hardware timestamp
From: Selvamani Rajagopal
Date: Wed Nov 18 2026 - 15:28:39 EST
> -----Original Message-----
> From: netdev-bot+sashiko@xxxxxxxxxx <netdev-bot+sashiko@xxxxxxxxxx>
> Sent: Tuesday, November 17, 2026 11:53 AM
> To: Selvamani Rajagopal <Selvamani.Rajagopal@xxxxxxxxxx>
> Subject: Re: [PATCH net-next v11 07/14] net: ethernet: oa_tc6: Support for hardware
> timestamp
>
>
> [Severity: Medium]
> Can all three TTSC slots get stuck so that every timestamped frame ends
> up here?
>
> Suppose the MAC-PHY never reports the capture for a frame that carried a
> TSC request. Examples are a frame discarded when MAC TXEN is cleared while
We are adding netdev_notifier callback to do the clean up when TXEN is cleared.
I would imagine TXEN would be cleared on device close where netdev would be
Marked down. Any capture events that come later would be taken care too.
>
> There is a separate problem with dropping the frame instead of sending it
> without a timestamp: any local socket can use up the slots. Once
> HWTSTAMP_TX_ON is enabled, SOF_TIMESTAMPING_TX_HARDWARE needs no
> capability. A socket that floods timestamp requests can keep all three
> slots busy. Other users' PTP event frames are then dropped, not just their
> timestamps.
Yes. Our internal team convinced me to send the frame without timestamp,
if all three slots are busy. Previously we were dropping it.
> --
> Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261113-s2500-
> mac-phy-support-v11-0-7a186141952c%40onsemi.com
> <https://url.usb.m.mimecastprotect.com/s/TebxC6YpngcrgR8jof6h7Qt5-
> Pre?domain=netdev-ai.bots.linux.dev>