Re: [PATCH net-next v3 1/2] net: sfp: add 2500base-X quirk for ODI DFP-34X-2C3

From: Andrew Lunn

Date: Wed Nov 18 2026 - 15:33:13 EST


On Wed, Nov 18, 2026 at 02:08:44PM -0600, icue.retsam.diman wrote:

>
> Hi Andrew,
>
> I tested the module without the quirk using an unmodified OpenWrt SNAPSHOT build (r38465-2ccaccdb98) for the GoodTop GT-SWTXG8FM (realtek/rtl930x).
>
> The ODI DFP-34X-2C3 successfully establishes a 1000base-X link with autonegotiation enabled.
>
> The ethtool lan8 output confirms:
>
> Advertised link modes: 1000baseX/Full
>
> Link partner advertised link modes: 1000baseX/Full
>
> Advertised auto-negotiation: Yes
>
> Link partner advertised auto-negotiation: Yes
>
> Speed: 1000Mb/s
>
> Duplex: Full
>
> Auto-negotiation: on
>
> Link detected: yes
>
> With the quirk, I was able to establish a 2500 Mb/s link with speed and duplex forced and autonegotiation disabled.
>
> Therefore, the module works with 1000base-X autonegotiation without the quirk, while the quirk enables 2500base-X operation.

Thanks for testing. You could add a Tested-by: if you want. That will
help get the change merge.

What i was afraid of is that for some reason 2500BaseX is rejected by
the other end, and it will only work at 1000BaseX. For a traditional
SFP, that would be true if the SFP on the other end of the fibre could
only do 1000BaseX. But this is not a traditional SFP, it is XPON. Can
the OLT say no to 2500BaseX, or is this purely down to what the ONT
can do?

Andrew