Re: [RFC PATCH 0/4] drm/tilcdc: Implement state readout

From: Màxim Pedraza Padilla

Date: Wed Nov 18 2026 - 16:21:28 EST


On Mon, Nov 16, 2026 at 05:50:31PM +0100, Maxime Ripard wrote:
> Awesome, thanks a lot for that. I was working on sending v9 today, so
> it's a nice timing :)
>
> There's some redundancy with some work I sent since v7, but it looks
> pretty ok.

Thanks! I based this on v7 and missed that v8 already covers patches 1
and 2 (the install hook fix and the panel bridge readout), so I'll drop
them and rebase the tilcdc part on top of v9.

> > - The U-Boot mode doesn't match the one in the DT (16.94 MHz pixel clock
> > and slightly different timings), so the first commit with the panel
> > mode does a full modeset, as expected.
>
> I'm not quite sure I understand what you meant here. If it does a full
> modeset, I would expect to see some flicker?

Sorry, that was unclear. Nothing happens at boot: the kernel keeps the
U-Boot mode and the logo stays untouched. The modeset only happens when
userspace does its first commit with the mode from the DT, which is also
when the logo gets replaced. On this panel the switch is clean, even on
a slow-motion video, but other panels may show a glitch. The real fix is
for U-Boot to program the same mode as the DT, and then that commit
doesn't need a modeset at all.

> Yeah, that's because I wasn't supporting partial pipeline updates in v7.
> It should be fixed in v8 onwards.

Great, I'll check the comparison again on v9.

Thanks,
Màxim