Re: [PATCH v3 03/11] dt-bindings: display/msm: Document Nord MDSS

From: Rob Herring

Date: Wed Nov 18 2026 - 16:23:13 EST


On Wed, Nov 18, 2026 at 05:51:23AM +0100, Shawn Guo wrote:
> On Mon, Nov 16, 2026 at 06:46:42PM +0530, Nabige Aala wrote:
> > From: Mahadevan P <mahadevan.p@xxxxxxxxxxxxxxxx>
> >
> > Nord has a new MDSS 12.1 revision with DPU 1499A and two independent,
> > DP-only display interface controllers (no DSI), which no existing
> > schema describes. Add a dedicated qcom,nord-mdss binding to document.
> >
> > Assisted-by: LLM
> > Signed-off-by: Mahadevan P <mahadevan.p@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Nabige Aala <nabige.aala@xxxxxxxxxxxxxxxx>
> > ---
> > .../bindings/display/msm/qcom,nord-mdss.yaml | 396 +++++++++++++++++++++
> > 1 file changed, 396 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml
> > new file mode 100644
> > index 000000000000..abd80dae4e7f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml
> > @@ -0,0 +1,396 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/msm/qcom,nord-mdss.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Nord display subsystem (MDSS)
> > +
> > +maintainers:
> > + - Mahadevan P <mahadevan.p@xxxxxxxxxxxxxxxx>
> > +
> > +description:
> > + Nord display subsystem consists of MDSS (display controller), DPU 1499A
> > + (display processing unit), and display interface controllers (DP only, no DSI).
> > + This is MDSS 12.1, DP-only, with 2 independent DP controllers.
> > +
> > +$ref: /schemas/display/msm/mdss-common.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: qcom,nord-mdss
> > +
> > + clocks:
> > + items:
> > + - description: Display AHB
> > + - description: Display hf AXI
> > + - description: Display core
> > +
> > + clock-names:
> > + items:
> > + - const: iface
> > + - const: bus
> > + - const: core
> > +
> > + iommus:
> > + maxItems: 1
> > +
> > + interconnects:
> > + items:
> > + - description: Interconnect path from mdp0 port to the data bus
> > + - description: Interconnect path from CPU to the reg bus
> > +
> > + interconnect-names:
> > + items:
> > + - const: mdp0-mem
> > + - const: cpu-cfg
> > +
> > +patternProperties:
> > + "^display-controller@[0-9a-f]+$":
> > + type: object
> > + additionalProperties: true
> > + properties:
> > + compatible:
> > + const: qcom,nord-dpu
> > +
> > + "^displayport-controller@[0-9a-f]+$":
> > + type: object
> > + additionalProperties: true
> > + properties:
> > + compatible:
> > + const: qcom,nord-dp
>
> This is now contradicting with the dp-controller bindings which documents
> "qcom,nord-dp" with a fallback on "qcom,sa8775p-dp".

The correct thing to do here is add 'contains'. We don't need to define
the exact value, but just have enough to ensure a schema is applied.

All these child nodes also need:

required:
- compatible

Rob