Re: [PATCH net v2] selftests: net: veth: propagate channel-check failures to exit status
From: Omokefe Emmanuel Onanaroghene
Date: Wed Nov 18 2026 - 19:41:47 EST
On Mon, 16 Nov 2026 21:50:01 +0000 netdev-bot+sashiko wrote:
> - [High] The fix is incomplete.
Legitimate, and already addressed: the three bad-setting checks
gained ret=1 in v3 [2/2] (also spotted by Tianyi during review),
restyled to if/else in v4 [2/2].
> - [Medium] Because chk_channels() now sets ret=1, the "setting
> invalid channels nr" check at
> tools/testing/selftests/net/veth.sh:467-468…
Good catch. Fixed by [3/3] in v4,
which attempts max_tx + 1 from the kernel-reported maximum
instead of nproc + 1.
pw-bot: cr