Re: [PATCH 1/2] rust: scatterlist: tie owned tables to the device's bound lifetime
From: Alexandre Courbot
Date: Wed Nov 18 2026 - 19:45:53 EST
On Thu Nov 19, 2026 at 7:45 AM JST, Danilo Krummrich wrote:
> On Mon Nov 16, 2026 at 5:02 AM CET, Alexandre Courbot wrote:
>> The `RawSGTable` documentation still mentions `Owned`. We could adapt it
>> or (maybe better) just drop that sentence.
>
> [...]
>
>> `sgt` is removed by this patch.
>
> diff --git a/rust/kernel/scatterlist.rs b/rust/kernel/scatterlist.rs
> index 93f431d7f548..22d039f3fdb1 100644
> --- a/rust/kernel/scatterlist.rs
> +++ b/rust/kernel/scatterlist.rs
> @@ -214,9 +214,6 @@ fn drop(&mut self) {
> }
>
> /// A transparent wrapper around a `struct sg_table`.
> -///
> -/// While we could also create the `struct sg_table` in the constructor of [`Owned`], we can't tear
> -/// down the `struct sg_table` in [`Owned::drop`]; the drop order in [`Owned`] matters.
> #[repr(transparent)]
> struct RawSGTable(Opaque<bindings::sg_table>);
>
> @@ -282,7 +279,6 @@ fn drop(&mut self) {
> /// A [`SGTable<Owned>`] signifies that the [`SGTable`] owns all associated resources:
> ///
> /// - The backing memory pages.
> -/// - The `struct sg_table` allocation (`sgt`).
> /// - The DMA mapping, released before the table and backing pages are freed.
> ///
> /// Users interact with this type through the [`SGTable`] handle and do not need to manage
With this,
Reviewed-by: Alexandre Courbot <acourbot@xxxxxxxxxx>