Re: [PATCH mm-new v2 4/5] mm/zsmalloc: remove unused zpdesc_lock()

From: Dev Jain

Date: Wed Nov 18 2026 - 23:36:32 EST




On 17/11/26 12:46 pm, Shivank Garg wrote:
> It was added in commit c1b3bb73d55e ("mm/zsmalloc: use zpdesc in

This was in late 2024 so seems fine.


> trylock_zspage()/lock_zspage()") but has never had a caller.
>
> Signed-off-by: Shivank Garg <shivankg@xxxxxxx>
> ---

Reviewed-by: Dev Jain <dev.jain@xxxxxxx>


> mm/zpdesc.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/mm/zpdesc.h b/mm/zpdesc.h
> index 4fd81c2e8076..aaab5f1bfb52 100644
> --- a/mm/zpdesc.h
> +++ b/mm/zpdesc.h
> @@ -107,11 +107,6 @@ static_assert(sizeof(struct zpdesc) <= sizeof(struct page));
> const struct page *: (const struct zpdesc *)(p), \
> struct page *: (struct zpdesc *)(p)))
>
> -static inline void zpdesc_lock(struct zpdesc *zpdesc)
> -{
> - folio_lock(zpdesc_folio(zpdesc));
> -}
> -
> static inline bool zpdesc_trylock(struct zpdesc *zpdesc)
> {
> return folio_trylock(zpdesc_folio(zpdesc));
>