Re: [PATCH v3 2/2] cpufreq: fix policy max not returning to non-boost freq on boost disable

From: Viresh Kumar

Date: Wed Nov 18 2026 - 23:49:28 EST


On 18-11-26, 17:59, Ananthu C V wrote:
> This does fix the issue of policy->max not being able to drop down back
> to non-boost values after boost disable, but I found another caveat.
>
> The commit 8c83947c5dbb added the following change a few months ago;
>
> static int cpufreq_policy_init_qos(struct cpufreq_policy *policy)
> {
> + unsigned int min_freq, max_freq;
> int ret;
>
> + /* Use policy->min/max set by the driver as QoS requests. */
> + min_freq = max(FREQ_QOS_MIN_DEFAULT_VALUE, policy->min);
> + if (policy->max)
> + max_freq = min(FREQ_QOS_MAX_DEFAULT_VALUE, policy->max);
> + else
> + max_freq = FREQ_QOS_MAX_DEFAULT_VALUE;
>
> this max_freq is then subsequently used to update max_freq_req constraint
> for the policy. This means, assigning a value to policy max in freq table
> directly will cause the same to be kept as the max_freq_req, which if
> boost is not enabled will be stuck at a non-boost value. The boost will
> still work, as policy max is set directly, but the value will be above
> the allowed qos max;
>
> # echo 1 > ../boost
> cpufreq: cpufreq: policy12 boost=1 policy->max=4723200 qos_max=4454400
> cpufreq: cpufreq: policy6 boost=1 policy->max=4723200 qos_max=4454400
>
> This also means if at any later point any limit refresh happens, the
> value will be brought back to that qos max, which is a non-boost value,
> even when boost is enabled;
>
> (e.g. here with a refresh_frequency_limits(policy); call after the boost)
>
> # echo 1 > ../boost
> cpufreq: cpufreq: policy12 boost=1 policy->max=4454400 qos_max=4454400
> cpufreq: cpufreq: policy6 boost=1 policy->max=4454400 qos_max=4454400
>
> tldr; is that it will fix the issue of the freq not dropping down from
> boost, but it will introduce a new potential problem of boost state
> potentially dropping back to non-boost freq while still in boost.
>
> So this alone can't be a fix at the very least. At the bare minimum it
> will need update to how max_freq_req is calculated/updated, etc. If
> nobody assigns values to policy->max before cpufreq_policy_init_qos
> is called, max_freq_req can simply use FREQ_QOS_MAX_DEFAULT_VALUE,
> which is S32_MAX, as its value, and not cause this problem, so the
> solution proposed in the current series will not run into this.
>
> > Also, can you please explain the issue again in detail. I am not very
> > sure how you are reaching to this issue over current mainline (without
> > the first patch).
>
> There are two issues the series is trying to address;
> 1. freq can go upto boost values, but they cannot be actually used
> 2. once a policy is using a boost value, that value cannot go back to a
> non boost value.
>
> So with or without patch 1, which addresses the first issue, the freq
> can still go to boost values, which can trigger the second issue. The
> logs relevant to the second issue, reusing from the cover letter, is;
>
> \# cd /sys/devices/system/cpu/cpufreq/
> \# ls
> boost policy0 policy12 policy6
> \# cat boost
> 0
> \# cat policy6/scaling_max_freq
> 4454400
> \# echo 1 > boost
> \# cat policy6/scaling_max_freq
> 4723200
> \# echo 0 > boost
> \# cat policy6/scaling_max_freq
> 472320
>
> The reason why this is happening is;
>
> from freq_table.c:
>
> if (policy->cpuinfo.max_freq < max_freq)
> policy->cpuinfo.max_freq = max_freq;
>
> and from cpufreq.c:
>
> freq_qos_update_request(&policy->boost_freq_req, policy->cpuinfo.max_freq);
>
> so cpuinfo.max_freq is only updated upwards, and that value is used to update
> boost_freq_req, which is a FREQ_QOS_MAX request. On boost enable and disable
> the cpuinfo.max_freq value stuck at the top will be used to update the qos
> max, and the value never comes down.

Pierre, any inputs ?

--
viresh