RE: [PATCH rtw-next] wifi: rtw88: find an associated station without allocating
From: Ping-Ke Shih
Date: Thu Nov 19 2026 - 00:20:52 EST
Mehmet Fide <mehmet.fide@xxxxxxxxx> wrote:
> From: Mehmet Fide <mehmet.fide@xxxxxxxxxxxxxxxxxx>
>
> rtw_core_check_sta_active() collects the interfaces with
> rtw_iterate_vifs(), which allocates an entry per interface with
> GFP_ATOMIC and skips the interface when that fails. A station skipped
> this way counts as not active: on BSS_CHANGED_BSSID and in
> rtw_ops_stop_ap() rtw_clear_op_chan() then drops the operating channel
> saved for it, and a later hardware scan no longer goes back to that
> channel between the channels it scans.
>
> Both callers hold the wiphy mutex. Walk the active interfaces with
> for_each_active_interface(), which does not allocate.
>
> Fixes: 96fbb84de4ff ("wifi: rtw88: handle station mode concurrent scan with AP mode")
I'd remove this Fixes, as my comment in Closes link.
> Reported-by: Luka Gejak <luka.gejak@xxxxxxxxx>
> Closes: https://lore.kernel.org/linux-wireless/9BC4FC13-5723-4711-9798-11E3C285C7F1@xxxxxxxxx/
> Suggested-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> Signed-off-by: Mehmet Fide <mehmet.fide@xxxxxxxxxxxxxxxxxx>
Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>