Re: [PATCH v6 3/7] x86/sev: Route unsupported APIC register accesses to the hypervisor APIC emulation

From: Borislav Petkov

Date: Thu Nov 19 2026 - 01:20:08 EST


On Fri, Nov 06, 2026 at 01:25:29AM +0000, Melody Wang wrote:
> - res = __vc_handle_msr(ghcb, &ctxt, false);
> + res = __vc_handle_msr(ghcb, &ctxt, write);
> if (res != ES_OK) {
> - pr_err("Secure AVIC MSR (0x%llx) read returned error (%d)\n", msr, res);
> - /* MSR read failures are treated as fatal errors */
> - sev_es_terminate(SEV_TERM_SET_LINUX, GHCB_TERM_SAVIC_FAIL);
> + pr_err("APIC MSR via GHCB (0x%llx) %s returned error (%d)\n", msr, write ? "write" : "read", res);

Make that line shorter and to the point:

pr_err("APIC GHCB %s MSR 0x%llx: error %d\n", write ? "write" : "read", msr, res);

> + /* MSR read/write failures are treated as fatal errors */
> + sev_es_terminate(SEV_TERM_SET_LINUX, GHCB_TERM_APIC_MSR_FAIL);
> }

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette