RE: [PATCH net-next v8 10/11] r8152: add TGPHY register access for RTL8157 and RTL8159
From: Chih Kai Hsu
Date: Thu Nov 19 2026 - 02:19:06 EST
On 19/11/2026 12:42 pm, Birger Koblitz wrote:
> On 18/11/2026 2:42 pm, Andrew Lunn wrote:
> >> I plan to add two new functions, rtl_nway_restart() and
> >> rtl8152_get_link_ksettings, to replace mii_nway_restart() and
> mii_ethtool_get_link_ksettings, respectively.
> >
> > Ideally, you should port this driver to phylink.
> >
> > Andrew
>
> Indeed, all of the (integrated) PHYs on the adapters supporeted by r8152 I
> looked at are already supported under drivers/net/phy/realtek/ It should be
> straight-forward with many immediate benefits.
>
> Birger
I agree that a phylink conversion is a better long-term direction. I'd like to
keep it out of this series. This series fixes and completes the existing RTL8157/59
support. The phylink conversion is a larger change. r8152 has no MDIO bus and
accesses PHY through OCP registers, and the MAC code also does PHY configuration,
firmware patching, UPS and EEE handling that would need to move or coexist with
the phylib drivers. The two helpers here are self-contained and will be removed by
the phylink port.
Best Regards,
Chih-Kai