Re: [PATCH v4 6/7] hwmon: Add driver for Marvel AlphaServer environmental sensors

From: Magnus Lindholm

Date: Thu Nov 19 2026 - 02:26:04 EST


Hi Guenter,

On Thu, Nov 19, 2026 at 5:17 AM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
> On 11/18/26 16:09, Matt Turner wrote:
> > The management firmware of the Marvel (EV7) AlphaServers, the GS1280,
> > ES80 and ES47, monitors temperatures, fans, voltages and power supplies.
> > The SRM console describes each sensor as a packet in a power and
> > environment node of its config tree (GCT), and fills in the readings
> > when asked to refresh the node. The packet layout was taken from Tru64
> > UNIX.
> >
> > The firmware gives each temperature, fan and voltage sensor a warning
> > limit and a failure limit, and reports the sensor in the warning or
> > failure state once its reading reaches one. Neither state means that the
> > sensor is broken: a temperature past its failure limit is too high, not
> > faulty. Power supplies are either working or failed, with the cause
> > (AC, POK, overtemperature, fan) logged by the firmware.
> >
> > Export the sensors through hwmon. A temperature's warning and failure
> > limits become max and crit, with max_alarm set in either state and
> > crit_alarm in the failure state. A fan's warning limit becomes min, with
> > min_alarm set in either state and fault in the failure state, which is
> > when the firmware counts the fan as failed. A voltage exports its
> > reading, with min_alarm or max_alarm set in either state and lcrit_alarm
> > or crit_alarm in the failure state, depending on which side of its
> > nominal voltage it reads. The console gives the nominal voltage and only
> > one other limit, so the voltage limits are not exported. A power supply
> > is a voltage channel with only a fault attribute.
> >
> > A refresh keeps the boot CPU in the console with interrupts disabled for
> > up to 300 ms per node, so refresh a node at most once every 10 seconds.
> > The hwmon core serializes the callbacks, which also
> > serializes the refreshes.
> >
> > The console callback lives in core_marvel.o, which generic kernels
> > built with ALPHA_LEGACY_START_ADDRESS leave out.
> >
> > Signed-off-by: Matt Turner <mattst88@xxxxxxxxx>
>
> Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>
> I assume thqat the series will be applied through an Alpha tree.
> Please let me know if I should apply this and the next patch
> through the hwmon-next tree.
>
> Thanks,
> Guenter
>

Yes, I plan to take the whole series through the Alpha tree.

Thanks a lot for your review and feedback, and for the ack.

Magnus