Re: [PATCH rtw-next v7 5/5] wifi: rtw89: honor ASSIGN_SEQ, retries, and NO_ACK for injected frames
From: Enver Ikromov
Date: Thu Nov 19 2026 - 03:03:12 EST
On Thu, Nov 19, 2026 at 07:27:53 +0000, Ping-Ke Shih wrote:
> Since RTL8852AE doesn't have NO_ACK in TX descriptor, so please note this
> in commit message.
>
> > @@ -1800,7 +1814,9 @@ static __le32 rtw89_build_txwd_body5_v2(struct rtw89_tx_desc_info *desc_info)
> >
> > static __le32 rtw89_build_txwd_body6_v2(struct rtw89_tx_desc_info *desc_info)
> > {
> > - u32 dword = FIELD_PREP(BE_TXD_BODY6_UPD_WLAN_HDR, desc_info->upd_wlan_hdr);
> > + u32 dword = FIELD_PREP(BE_TXD_BODY6_NO_ACK, desc_info->no_ack) |
> > + FIELD_PREP(BE_TXD_BODY6_UPD_WLAN_HDR,
> > + desc_info->upd_wlan_hdr);
>
> Just straighten as original (a little over 80 characters).
Thanks for reviewing the series! I will note the missing TX descriptor
NO_ACK field on Wi-Fi 6 chips such as RTL8852AE in the commit message,
unwrap rtw89_build_txwd_body6_v2(), and fold in the Fixes tag and blank
line on patches 1 and 4 in v8.
Thanks,
Enver