[PATCH] accel/qaic: hold the dma_resv lock when mapping imported buffers
From: Wang Haoran
Date: Thu Nov 19 2026 - 03:16:11 EST
qaic_prepare_import_bo() maps an imported dma-buf with
dma_buf_map_attachment() and qaic_unprepare_import_bo() unmaps it with
dma_buf_unmap_attachment(). Those are the locked variants: the dma-buf
locking convention requires importers to hold the buffer's reservation
lock when calling them, and both assert it via dma_resv_assert_held(),
i.e. lockdep_assert_held() on attach->dmabuf->resv.
qaic calls both without holding the reservation lock, so on a
lockdep-enabled kernel every slice attach/detach against an imported
buffer trips the lockdep assertion (a WARNING with a backtrace). The
reservation lock also serializes the importer against the exporter
moving or invalidating the buffer's backing storage for a dynamic
attachment, so an unlocked map can race that move and use a stale
sg_table.
Hold the reservation lock around the map and unmap calls, which is
equivalent to the dedicated dma_buf_map_attachment_unlocked() and
dma_buf_unmap_attachment_unlocked() helpers.
Signed-off-by: Wang Haoran <wanghr2026@xxxxxxxxxxxxxxxxxx>
Fixes: ff13be830333 ("accel/qaic: Add datapath")
---
diff --git a/drivers/accel/qaic/qaic_data.c b/drivers/accel/qaic/qaic_data.c
index ee35e13091b3..0b57f8d544a2 100644
--- a/drivers/accel/qaic/qaic_data.c
+++ b/drivers/accel/qaic/qaic_data.c
@@ -895,7 +895,9 @@ static int qaic_prepare_import_bo(struct qaic_bo *bo, struct qaic_attach_slice_h
struct sg_table *sgt;
int ret;
+ dma_resv_lock(obj->resv, NULL);
sgt = dma_buf_map_attachment(obj->import_attach, hdr->dir);
+ dma_resv_unlock(obj->resv);
if (IS_ERR(sgt)) {
ret = PTR_ERR(sgt);
return ret;
@@ -936,7 +938,9 @@ static int qaic_prepare_bo(struct qaic_device *qdev, struct qaic_bo *bo,
static void qaic_unprepare_import_bo(struct qaic_bo *bo)
{
+ dma_resv_lock(bo->base.resv, NULL);
dma_buf_unmap_attachment(bo->base.import_attach, bo->sgt, bo->dir);
+ dma_resv_unlock(bo->base.resv);
bo->sgt = NULL;
}
---
The vulnerability was found by static analysis.