Re: [PATCH 00/15] accel: Add AMD Versal AI Engine driver (with Versal Gen 2 firmware support)
From: Jerome Brunet
Date: Thu Nov 19 2026 - 03:20:04 EST
On mer. 18 nov. 2026 at 15:31, Gregory Williams <gregory.williams@xxxxxxx> wrote:
> This series adds a driver for the AMD AI Engine (AIE) found on Versal
> devices, together with the firmware changes the driver depends on. AI Engine
> is a tile array based accelerator used for applications such as beamforming and
> machine learning inference. Tiles are organised in columns, and groups of
> columns form partitions that an application requests, initialises and releases.
>
> Several registers in the AI Engine array (column and shim resets, memory
> zeroisation, tile clock gating, NoC and interrupt routing) are privileged
> and can only be written by the trusted firmware. The driver therefore
> packs operations into a DMA buffer and hands it to the platform firmware,
> which executes them in order.
>
> Firmware patches included
> -------------------------
> Patches 1-10 are not part of the AI Engine driver itself, but the driver
> cannot work without them, so they are included here to keep the series
> self-contained and reviewable in one place:
>
> - 1-5: zynqmp firmware driver refactoring and a va_start()/va_end()
> fix (patch 2 carries Fixes: tags), preparing for the extended
> SMCCC call format.
> - 6-7: Versal Gen 2 compatible string and firmware support, where all
> EEMI APIs use the extended SMCCC payload.
> - 8-9: Versal Gen 2 clock binding and clk driver match entry.
> - 10: firmware IOCTL support for the Versal Gen 2 AIE run time
> operations, used by the driver.
>
> I am happy to split out or reorder the firmware and clock patches if the
> maintainers prefer to take them through their own trees, and would
> appreciate guidance on how the series should be merged.
For the clock, it would defenitely be prefered if you could split out
clock part, especially if you later need an immutable branch.
`b4` makes it very easy to handle series deps, please consider using the
related tags
https://b4.docs.kernel.org/en/latest/contributor/prep.html#working-with-series-dependencies
>
> AI Engine driver
> ----------------
> - 11: devicetree binding for the AI Engine.
> - 12: driver core: device probe, partition request and release.
> - 13: pm ops: building and sending firmware operation packets.
> - 14: enabling and disabling tile clocks.
> - 15: partition initialize and teardown (reset operations).
>
> Previous submission
> -------------------
> This driver was posted for review a little over a year ago:
>
> https://lore.kernel.org/dri-devel/20250702155630.1737227-1-gregory.williams@xxxxxxx/
>
> Since then the scope of what is proposed for upstream has changed, this series
> is considerably different from that posting, in particular targeting only Versal
> Gen 2 support. All comments received on the earlier posting have been addressed
> or in this version.
>
> Abhyuday Godhasara (1):
> drivers: firmware: xilinx: Add IOCTL support for the AIE run time
> operations
>
> Gregory Williams (5):
> dt-bindings: soc: xilinx: Add Versal AI Engine DT binding
> accel/amd-ai-engine: Add AMD AI Engine device driver
> accel/amd-ai-engine: Add pm ops for firmware calls
> accel/amd-ai-engine: Add support to enable/disable tile clocks
> accel/amd-ai-engine: Add reset operations
>
> Naman Trivedi (1):
> dt-bindings: clock: versal: add Versal Gen 2 compatible string
>
> Senthil Nathan Thangaraj (8):
> firmware: xilinx: Separate TF-A checking
> firmware: xilinx: Call va_start after pm feature check
> firmware: xilinx: Add comments about number of arguments
> firmware: xilinx: Use match data for ZynqMP/Versal
> firmware: xilinx: Rename zynqmp_pm_invoke_fw_fn()
> dt-bindings: firmware: xilinx: Add Versal Gen 2 compatible string
> firmware: xilinx: Add support for Versal Gen 2
> clk: zynqmp: Add Versal Gen 2 compatible string
>
> .../bindings/clock/xlnx,versal-clk.yaml | 5 +-
> .../firmware/xilinx/xlnx,zynqmp-firmware.yaml | 3 +
> .../bindings/soc/xilinx/xlnx,ai-engine.yaml | 61 +++
> MAINTAINERS | 9 +
> drivers/accel/Kconfig | 1 +
> drivers/accel/Makefile | 3 +-
> drivers/accel/amd-ai-engine/Kconfig | 15 +
> drivers/accel/amd-ai-engine/Makefile | 14 +
> .../accel/amd-ai-engine/ai-engine-aiemlv2.c | 441 ++++++++++++++++
> drivers/accel/amd-ai-engine/ai-engine-clock.c | 154 ++++++
> drivers/accel/amd-ai-engine/ai-engine-dev.c | 255 ++++++++++
> .../accel/amd-ai-engine/ai-engine-internal.h | 377 ++++++++++++++
> drivers/accel/amd-ai-engine/ai-engine-part.c | 140 ++++++
> drivers/accel/amd-ai-engine/ai-engine-pm.c | 472 ++++++++++++++++++
> drivers/accel/amd-ai-engine/ai-engine-res.c | 184 +++++++
> drivers/accel/amd-ai-engine/ai-engine-reset.c | 69 +++
> drivers/clk/zynqmp/clkc.c | 1 +
> drivers/firmware/xilinx/zynqmp.c | 340 +++++++++++--
> include/linux/amd-ai-engine.h | 115 +++++
> include/linux/firmware/xlnx-zynqmp.h | 65 ++-
> 20 files changed, 2679 insertions(+), 45 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/soc/xilinx/xlnx,ai-engine.yaml
> create mode 100644 drivers/accel/amd-ai-engine/Kconfig
> create mode 100644 drivers/accel/amd-ai-engine/Makefile
> create mode 100644 drivers/accel/amd-ai-engine/ai-engine-aiemlv2.c
> create mode 100644 drivers/accel/amd-ai-engine/ai-engine-clock.c
> create mode 100644 drivers/accel/amd-ai-engine/ai-engine-dev.c
> create mode 100644 drivers/accel/amd-ai-engine/ai-engine-internal.h
> create mode 100644 drivers/accel/amd-ai-engine/ai-engine-part.c
> create mode 100644 drivers/accel/amd-ai-engine/ai-engine-pm.c
> create mode 100644 drivers/accel/amd-ai-engine/ai-engine-res.c
> create mode 100644 drivers/accel/amd-ai-engine/ai-engine-reset.c
> create mode 100644 include/linux/amd-ai-engine.h
>
> --
> 2.34.1
>
--
Jerome