Re: [PATCH 0/8] s390: Add __must_check to set_memory() primitives
From: Mike Rapoport
Date: Thu Nov 19 2026 - 03:29:22 EST
On Wed, Nov 18, 2026 at 03:47:01PM +0100, Heiko Carstens wrote:
> A small series which adds missing return value checks of set_memory()
> calls to s390 specific call sites. Also add __must_check to set_memory()
> primitives in order to avoid that new unchecked callers will be added.
>
> This is basically the same what was done for powerpc with [1].
>
> Note that this (trivially) conflicts with [2]. Furthermore the kexec code
> is the only call site which for now only prints an error message instead
> of really handling the error, since error handling in common code is
> missing. That needs to be added with later changes.
>
> While doing this conversion I realized that s390's execmem support also
> can be improved. Will happen with a follow-on series.
>
> [1] 2abbd6d5fbe0 ("powerpc: Add __must_check to set_memory_...()")
> [2] https://lore.kernel.org/all/20261117-fixes-s390-v1-1-2d9d04ca0072@xxxxxxxxxx/
>
> Thanks,
> Heiko
>
> Heiko Carstens (8):
> s390/kfence: Add error handling to arch_kfence_init_pool()
> s390/kprobes: Add error handling to alloc_insn_page()
> s390/kexec: Let crash_protect_pages() warn in case of an error
> s390/module: Add error handling to module_alloc_ftrace_hotpatch_trampolines()
> s390/mm: Add error handling to arch_setup_zero_pages()
> s390/mm: Add error handling to mark_rodata_ro()
> s390/mm: Add error handling to vmem_map_init()
> s390/set_memory: Add __must_check to set_memory() primitives
For the series:
Acked-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
> arch/s390/include/asm/kfence.h | 3 ++-
> arch/s390/include/asm/set_memory.h | 4 ++--
> arch/s390/kernel/kprobes.c | 5 ++++-
> arch/s390/kernel/machine_kexec.c | 7 +++++--
> arch/s390/kernel/module.c | 7 ++++++-
> arch/s390/mm/init.c | 10 ++++++++--
> arch/s390/mm/vmem.c | 14 +++++++++-----
> 7 files changed, 36 insertions(+), 14 deletions(-)
>
> base-commit: 666539eecdf4db623f5e3c3e55cf9f2dfad24aa4
> --
> 2.56.1
--
Sincerely yours,
Mike.